Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 459463002: ES6: Duplicate properties are no longer an error (Closed)

Created:
6 years, 4 months ago by arv (Not doing code reviews)
Modified:
6 years, 4 months ago
Reviewers:
wingo, marja
CC:
rossberg, v8-dev
Project:
v8
Visibility:
Public.

Description

ES6: Duplicate properties are no longer an error This removes the duplicate property checker and updates the tests. BUG=v8:3498 LOG=Y R=marja@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23239

Patch Set 1 #

Patch Set 2 : Fix more tests #

Patch Set 3 : Update webkit test too #

Total comments: 2

Patch Set 4 : Add test for number literals that was previously part of duplicate property test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -343 lines) Patch
M src/preparser.h View 5 chunks +0 lines, -92 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 4 chunks +20 lines, -19 lines 0 comments Download
A test/mjsunit/number-literal.js View 1 2 3 1 chunk +33 lines, -0 lines 0 comments Download
M test/mjsunit/strict-mode.js View 2 chunks +46 lines, -42 lines 0 comments Download
D test/preparser/duplicate-property.pyt View 1 chunk +0 lines, -162 lines 0 comments Download
M test/webkit/object-literal-syntax.js View 1 2 1 chunk +14 lines, -14 lines 0 comments Download
M test/webkit/object-literal-syntax-expected.txt View 1 2 2 chunks +15 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
arv (Not doing code reviews)
PTAL
6 years, 4 months ago (2014-08-08 19:30:41 UTC) #1
arv (Not doing code reviews)
Fix more tests
6 years, 4 months ago (2014-08-08 22:09:18 UTC) #2
arv (Not doing code reviews)
6 years, 4 months ago (2014-08-11 16:39:09 UTC) #3
arv (Not doing code reviews)
Update webkit test too
6 years, 4 months ago (2014-08-11 17:51:55 UTC) #4
marja
lgtm modulo 2 comments - great that this code is no longer needed! :) 1) ...
6 years, 4 months ago (2014-08-12 07:47:44 UTC) #5
arv (Not doing code reviews)
Thanks for the review I'll run the blink layout tests and disable/update the tests on ...
6 years, 4 months ago (2014-08-12 14:08:37 UTC) #6
arv (Not doing code reviews)
Add test for number literals that was previously part of duplicate property test
6 years, 4 months ago (2014-08-12 18:09:51 UTC) #7
arv (Not doing code reviews)
Blink TestExpectation suppression: https://codereview.chromium.org/467903003
6 years, 4 months ago (2014-08-13 16:16:37 UTC) #8
arv (Not doing code reviews)
6 years, 4 months ago (2014-08-20 14:25:56 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 manually as 23239 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698