Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 467903003: Remove duplicate property test (Closed)

Created:
6 years, 4 months ago by arv (Not doing code reviews)
Modified:
6 years, 4 months ago
Reviewers:
Dirk Pranke, adamk
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Remove duplicate property test In ES6, these are now allowed in both strict and sloppy mode. These tests will fail when v8:3498 lands and gets rolled. BUG=403353 R=dpranke@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180197

Patch Set 1 #

Patch Set 2 : Remove tests instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -737 lines) Patch
D LayoutTests/fast/js/mozilla/strict/11.1.5.html View 1 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/js/mozilla/strict/script-tests/11.1.5.js View 1 1 chunk +0 lines, -173 lines 0 comments Download
D LayoutTests/ietestcenter/Javascript/11.1.5_4-4-b-1.html View 1 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/ietestcenter/Javascript/11.1.5_4-4-b-2.html View 1 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/ietestcenter/Javascript/11.1.5_4-4-c-1.html View 1 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/ietestcenter/Javascript/11.1.5_4-4-c-2.html View 1 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/ietestcenter/Javascript/11.1.5_4-4-d-1.html View 1 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/ietestcenter/Javascript/11.1.5_4-4-d-2.html View 1 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/ietestcenter/Javascript/11.1.5_4-4-d-3.html View 1 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/ietestcenter/Javascript/11.1.5_4-4-d-4.html View 1 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/ietestcenter/Javascript/TestCases/11.1.5_4-4-b-1.js View 1 1 chunk +0 lines, -55 lines 0 comments Download
D LayoutTests/ietestcenter/Javascript/TestCases/11.1.5_4-4-b-2.js View 1 1 chunk +0 lines, -55 lines 0 comments Download
D LayoutTests/ietestcenter/Javascript/TestCases/11.1.5_4-4-c-1.js View 1 1 chunk +0 lines, -56 lines 0 comments Download
D LayoutTests/ietestcenter/Javascript/TestCases/11.1.5_4-4-c-2.js View 1 1 chunk +0 lines, -56 lines 0 comments Download
D LayoutTests/ietestcenter/Javascript/TestCases/11.1.5_4-4-d-1.js View 1 1 chunk +0 lines, -55 lines 0 comments Download
D LayoutTests/ietestcenter/Javascript/TestCases/11.1.5_4-4-d-2.js View 1 1 chunk +0 lines, -56 lines 0 comments Download
D LayoutTests/ietestcenter/Javascript/TestCases/11.1.5_4-4-d-3.js View 1 1 chunk +0 lines, -56 lines 0 comments Download
D LayoutTests/ietestcenter/Javascript/TestCases/11.1.5_4-4-d-4.js View 1 1 chunk +0 lines, -56 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
arv (Not doing code reviews)
What is the right way to do this? These test are never going to pass ...
6 years, 4 months ago (2014-08-13 16:15:28 UTC) #1
Dirk Pranke
On 2014/08/13 16:15:28, arv wrote: > What is the right way to do this? These ...
6 years, 4 months ago (2014-08-13 16:58:49 UTC) #2
arv (Not doing code reviews)
On 2014/08/13 at 16:58:49, dpranke wrote: > On 2014/08/13 16:15:28, arv wrote: > > What ...
6 years, 4 months ago (2014-08-13 17:39:06 UTC) #3
arv (Not doing code reviews)
Remove tests instead
6 years, 4 months ago (2014-08-13 17:48:40 UTC) #4
Dirk Pranke
lgtm. delete away :).
6 years, 4 months ago (2014-08-13 17:55:54 UTC) #5
arv (Not doing code reviews)
6 years, 4 months ago (2014-08-13 17:59:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as 180197 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698