Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issue 459433002: By default don't output results.html for recordings. (Closed)

Created:
6 years, 4 months ago by ariblue
Modified:
6 years, 4 months ago
Reviewers:
nednguyen, chrishenry
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

By default don't output results.html for recordings. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288468

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M tools/telemetry/telemetry/page/record_wpr.py View 1 2 chunks +5 lines, -0 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
ariblue
6 years, 4 months ago (2014-08-08 18:32:59 UTC) #1
chrishenry
lgtm https://codereview.chromium.org/459433002/diff/1/tools/telemetry/telemetry/page/record_wpr.py File tools/telemetry/telemetry/page/record_wpr.py (right): https://codereview.chromium.org/459433002/diff/1/tools/telemetry/telemetry/page/record_wpr.py#newcode112 tools/telemetry/telemetry/page/record_wpr.py:112: default_options = {'output_format': 'none'} Let's just inline this?
6 years, 4 months ago (2014-08-08 19:45:04 UTC) #2
ariblue
https://codereview.chromium.org/459433002/diff/1/tools/telemetry/telemetry/page/record_wpr.py File tools/telemetry/telemetry/page/record_wpr.py (right): https://codereview.chromium.org/459433002/diff/1/tools/telemetry/telemetry/page/record_wpr.py#newcode112 tools/telemetry/telemetry/page/record_wpr.py:112: default_options = {'output_format': 'none'} On 2014/08/08 19:45:04, chrishenry wrote: ...
6 years, 4 months ago (2014-08-08 19:54:40 UTC) #3
nednguyen
lgtm
6 years, 4 months ago (2014-08-08 20:01:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ariblue@google.com/459433002/20001
6 years, 4 months ago (2014-08-08 20:04:46 UTC) #5
nednguyen
https://codereview.chromium.org/459433002/diff/20001/tools/telemetry/telemetry/page/record_wpr.py File tools/telemetry/telemetry/page/record_wpr.py (right): https://codereview.chromium.org/459433002/diff/20001/tools/telemetry/telemetry/page/record_wpr.py#newcode149 tools/telemetry/telemetry/page/record_wpr.py:149: self._benchmark.SetArgumentDefaults(self._parser) Actually, what would happen if this benchmark set ...
6 years, 4 months ago (2014-08-08 20:06:53 UTC) #6
ariblue
https://codereview.chromium.org/459433002/diff/20001/tools/telemetry/telemetry/page/record_wpr.py File tools/telemetry/telemetry/page/record_wpr.py (right): https://codereview.chromium.org/459433002/diff/20001/tools/telemetry/telemetry/page/record_wpr.py#newcode149 tools/telemetry/telemetry/page/record_wpr.py:149: self._benchmark.SetArgumentDefaults(self._parser) On 2014/08/08 20:06:53, nednguyen wrote: > Actually, what ...
6 years, 4 months ago (2014-08-08 20:13:59 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 23:37:01 UTC) #8
Message was sent while issue was closed.
Change committed as 288468

Powered by Google App Engine
This is Rietveld 408576698