Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: tools/telemetry/telemetry/page/record_wpr.py

Issue 459433002: By default don't output results.html for recordings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comment Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/record_wpr.py
diff --git a/tools/telemetry/telemetry/page/record_wpr.py b/tools/telemetry/telemetry/page/record_wpr.py
index ba25594793ac7285bdafd67c1288393fc0ec5e2d..71c279816b827abeaba7c80266d2225c1219d493 100755
--- a/tools/telemetry/telemetry/page/record_wpr.py
+++ b/tools/telemetry/telemetry/page/record_wpr.py
@@ -108,6 +108,7 @@ def _MaybeGetInstanceOfClass(target, base_dir, cls):
class WprRecorder(object):
+
def __init__(self, base_dir, target, args=None):
action_names_to_run = FindAllActionNames(base_dir)
self._record_page_test = RecorderPageTest(action_names_to_run)
@@ -146,6 +147,10 @@ class WprRecorder(object):
if self._benchmark is not None:
self._benchmark.AddCommandLineArgs(self._parser)
self._benchmark.SetArgumentDefaults(self._parser)
nednguyen 2014/08/08 20:06:53 Actually, what would happen if this benchmark set
ariblue 2014/08/08 20:13:58 The later default set will take precedence, correc
+ self._SetArgumentDefaults()
+
+ def _SetArgumentDefaults(self):
+ self._parser.set_defaults(**{'output_format': 'none'})
def _ParseArgs(self, args=None):
args_to_parse = sys.argv[1:] if args is None else args
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698