Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 459413002: Support symbol-named properties in API (Closed)

Created:
6 years, 4 months ago by wingo
Modified:
6 years, 4 months ago
Reviewers:
dcarney, rossberg
CC:
v8-dev, Paweł Hajdan Jr., yhirano
Project:
v8
Visibility:
Public.

Description

Support symbol-named properties in API Add new "Name" type to API that is a supertype of Symbol and String. Object::SetDeclaredAccessor, Object::SetAccessorProperty, Template::Set, Template::SetAccessorProperty, and Template::SetDeclaredAccessor now take a Name as the property name instead of a String. Add Object::SetAccessor, Template::SetNativeDataProperty, and ObjectTemplate::SetAccessor overloads that can define accessors for symbol-named properties. R=dcarney@chromium.org, rossberg@chromium.org BUG=v8:3394 TEST=cctest/test-api/TestSymbolProperties LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=23247

Patch Set 1 : #

Patch Set 2 : Include a bit that was missing from the previous patch #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -114 lines) Patch
M include/v8.h View 10 chunks +65 lines, -9 lines 0 comments Download
M src/accessors.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
M src/accessors.cc View 1 44 chunks +46 lines, -46 lines 0 comments Download
M src/api.h View 4 chunks +6 lines, -2 lines 0 comments Download
M src/api.cc View 1 15 chunks +64 lines, -16 lines 1 comment Download
M src/arguments.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/arm64/simulator-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/assembler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/objects.cc View 1 5 chunks +10 lines, -17 lines 0 comments Download
M src/stub-cache.cc View 1 1 chunk +3 lines, -7 lines 0 comments Download
M test/cctest/test-alloc.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 6 chunks +49 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
wingo
The bulk of the changes in this patch are to the API layer. They are ...
6 years, 4 months ago (2014-08-12 12:12:03 UTC) #1
wingo
I should also mention that I didn't "git cl format" on this one, as it ...
6 years, 4 months ago (2014-08-12 12:19:44 UTC) #2
dcarney
lgtm
6 years, 4 months ago (2014-08-12 18:01:27 UTC) #3
rossberg
lgtm https://codereview.chromium.org/459413002/diff/40001/src/api.cc File src/api.cc (left): https://codereview.chromium.org/459413002/diff/40001/src/api.cc#oldcode3420 src/api.cc:3420: Setter getter, OMG...
6 years, 4 months ago (2014-08-19 11:19:27 UTC) #4
wingo
6 years, 4 months ago (2014-08-20 15:25:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as 23247.

Powered by Google App Engine
This is Rietveld 408576698