src/assembler.h - Issue 459413002: Support symbol-named properties in API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/assembler.h

Issue 459413002: Support symbol-named properties in API (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Include a bit that was missing from the previous patch Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/assembler.h

diff --git a/src/assembler.h b/src/assembler.h

index a128c09d095f5446652fc42379372620ee9052c1..a293c398a3bcd5a5012ad2775ae65a8a7f1ab944 100644

--- a/src/assembler.h

+++ b/src/assembler.h

@@ -774,12 +774,12 @@ class ExternalReference BASE_EMBEDDED {

PROFILING_API_CALL,

// Direct call to accessor getter callback.

- // void f(Local<String> property, PropertyCallbackInfo& info)

+ // void f(Local<Name> property, PropertyCallbackInfo& info)

DIRECT_GETTER_CALL,

// Call to accessor getter callback via InvokeAccessorGetterCallback.

- // void f(Local<String> property, PropertyCallbackInfo& info,

- // AccessorGetterCallback callback)

+ // void f(Local<Name> property, PropertyCallbackInfo& info,

+ // AccessorNameGetterCallback callback)

PROFILING_GETTER_CALL

};