DevTools: Added service workers to remote debugging targets

content/browser/devtools/embedded_worker_devtools_agent_host.cc

Index: content/browser/devtools/embedded_worker_devtools_agent_host.cc
diff --git a/content/browser/devtools/embedded_worker_devtools_agent_host.cc b/content/browser/devtools/embedded_worker_devtools_agent_host.cc
index 9f604001134b61ba4a11c8e40974e723e8b516e5..c27354a3def0cafc8a7c2cabcdfff62ee30117d8 100644
--- a/content/browser/devtools/embedded_worker_devtools_agent_host.cc
+++ b/content/browser/devtools/embedded_worker_devtools_agent_host.cc
@@ -38,6 +38,26 @@ bool EmbeddedWorkerDevToolsAgentHost::IsWorker() const {
   return true;
 }
 
+std::string EmbeddedWorkerDevToolsAgentHost::GetType() {
+  return shared_worker_ ? kAgentHostTypeWorker : kAgentHostTypeServiceWorker;
+}
+
+std::string EmbeddedWorkerDevToolsAgentHost::GetTitle() {
+  return "";

[yurys, 2014/08/13 07:33:46]

 shared_worker_ has both name and url so you should be able to retrieve them.
Also it might make sense to have to descendants for service and shared worker to
avoid repetitive ifs.

[vkuzkokov, 2014/08/13 08:21:06]

Implemented GetTitle() and GetURL() for shared workers.
I'd prefer a separate patch for splitting EWDTAH into 2 implementations.

+}
+
+GURL EmbeddedWorkerDevToolsAgentHost::GetURL() {
+  return GURL();
+}
+
+bool EmbeddedWorkerDevToolsAgentHost::Activate() {
+  return false;
+}
+
+bool EmbeddedWorkerDevToolsAgentHost::Close() {
+  return false;

[yurys, 2014/08/13 07:33:46]

I guess we can easily implement this method.

[vkuzkokov, 2014/08/13 08:21:06]

Easily - for shared workers. For service workers it requires modifications in
EmbeddedWorkerInstance (as seen in crrev.com/349033009)

+}
+
 void EmbeddedWorkerDevToolsAgentHost::SendMessageToAgent(
     IPC::Message* message_raw) {
   scoped_ptr<IPC::Message> message(message_raw);