DevTools: Added service workers to remote debugging targets

content/browser/devtools/embedded_worker_devtools_agent_host.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/embedded_worker_devtools_agent_host.h"
 
 #include "content/browser/devtools/devtools_manager_impl.h"
 #include "content/browser/devtools/devtools_protocol.h"
 #include "content/browser/devtools/devtools_protocol_constants.h"
 #include "content/common/devtools_messages.h"
@@ skipping 20 matching lines @@
       worker_id_(worker_id) {
   if (debug_service_worker_on_start)
     state_ = WORKER_PAUSED_FOR_DEBUG_ON_START;
   WorkerCreated();
 }
 
 bool EmbeddedWorkerDevToolsAgentHost::IsWorker() const {
   return true;
 }
 
+std::string EmbeddedWorkerDevToolsAgentHost::GetType() {
+  return shared_worker_ ? kAgentHostTypeWorker : kAgentHostTypeServiceWorker;
+}
+
+std::string EmbeddedWorkerDevToolsAgentHost::GetTitle() {
+  return "";

[yurys, 2014/08/13 07:33:46]

 shared_worker_ has both name and url so you should be able to retrieve them.
Also it might make sense to have to descendants for service and shared worker to
avoid repetitive ifs.

[vkuzkokov, 2014/08/13 08:21:06]

Implemented GetTitle() and GetURL() for shared workers.
I'd prefer a separate patch for splitting EWDTAH into 2 implementations.

+}
+
+GURL EmbeddedWorkerDevToolsAgentHost::GetURL() {
+  return GURL();
+}
+
+bool EmbeddedWorkerDevToolsAgentHost::Activate() {
+  return false;
+}
+
+bool EmbeddedWorkerDevToolsAgentHost::Close() {
+  return false;

[yurys, 2014/08/13 07:33:46]

I guess we can easily implement this method.

[vkuzkokov, 2014/08/13 08:21:06]

Easily - for shared workers. For service workers it requires modifications in
EmbeddedWorkerInstance (as seen in crrev.com/349033009)

+}
+
 void EmbeddedWorkerDevToolsAgentHost::SendMessageToAgent(
     IPC::Message* message_raw) {
   scoped_ptr<IPC::Message> message(message_raw);
   if (state_ != WORKER_INSPECTED)
     return;
   if (RenderProcessHost* host = RenderProcessHost::FromID(worker_id_.first)) {
     message->set_routing_id(worker_id_.second);
     host->Send(message.release());
   }
 }
@@ skipping 99 matching lines @@
   DevToolsManagerImpl::GetInstance()->DispatchOnInspectorFrontend(
       this, message);
 }
 
 void EmbeddedWorkerDevToolsAgentHost::OnSaveAgentRuntimeState(
     const std::string& state) {
   saved_agent_state_ = state;
 }
 
 }  // namespace content