Issue 459313002: Oilpan: RenderMenuList should call PopupMenu::disconnectClient in destroy().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 459313002: Oilpan: RenderMenuList should call PopupMenu::disconnectClient in destroy(). (Closed)

Created:
6 years, 4 months ago by tkent

Modified:
6 years, 4 months ago

Reviewers:
keishi, oilpan-reviews, haraken

CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Oilpan: RenderMenuList should call PopupMenu::disconnectClient in destroy(). PopupMenu::disconnectClient accesses some objects, and they might be destructed when a RenderMenuList object is garbage collected. We should call PopupMenu::disconnectClient earlier. This fixes SelectPopupMenuStyleTest.PopupListBoxRTLRowWidth in Oilpan. BUG=402439 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180023

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	Source/core/rendering/RenderMenuList.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/core/rendering/RenderMenuList.cpp	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/459313002/1

6 years, 4 months ago (2014-08-12 01:35:57 UTC) #4

Message was sent while issue was closed.

Change committed as 180023

Expand Messages | Collapse Messages