Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Side by Side Diff: Source/core/rendering/RenderMenuList.h

Issue 459313002: Oilpan: RenderMenuList should call PopupMenu::disconnectClient in destroy(). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/rendering/RenderMenuList.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of the select element renderer in WebCore. 2 * This file is part of the select element renderer in WebCore.
3 * 3 *
4 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 4 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
5 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserv ed. 5 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserv ed.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 21 matching lines...) Expand all
32 namespace blink { 32 namespace blink {
33 33
34 class HTMLSelectElement; 34 class HTMLSelectElement;
35 class RenderText; 35 class RenderText;
36 36
37 class RenderMenuList FINAL : public RenderFlexibleBox, private PopupMenuClient { 37 class RenderMenuList FINAL : public RenderFlexibleBox, private PopupMenuClient {
38 38
39 public: 39 public:
40 RenderMenuList(Element*); 40 RenderMenuList(Element*);
41 virtual ~RenderMenuList(); 41 virtual ~RenderMenuList();
42 virtual void destroy() OVERRIDE;
42 virtual void trace(Visitor*) OVERRIDE; 43 virtual void trace(Visitor*) OVERRIDE;
43 44
44 public:
45 bool popupIsVisible() const { return m_popupIsVisible; } 45 bool popupIsVisible() const { return m_popupIsVisible; }
46 void showPopup(); 46 void showPopup();
47 void hidePopup(); 47 void hidePopup();
48 48
49 void setOptionsChanged(bool changed) { m_optionsChanged = changed; } 49 void setOptionsChanged(bool changed) { m_optionsChanged = changed; }
50 50
51 void didSetSelectedIndex(int listIndex); 51 void didSetSelectedIndex(int listIndex);
52 52
53 String text() const; 53 String text() const;
54 54
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 131
132 RefPtr<PopupMenu> m_popup; 132 RefPtr<PopupMenu> m_popup;
133 bool m_popupIsVisible; 133 bool m_popupIsVisible;
134 }; 134 };
135 135
136 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderMenuList, isMenuList()); 136 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderMenuList, isMenuList());
137 137
138 } 138 }
139 139
140 #endif 140 #endif
OLDNEW
« no previous file with comments | « no previous file | Source/core/rendering/RenderMenuList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698