Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 459243002: Re-enable shared module tests on windows (Closed)

Created:
6 years, 4 months ago by elijahtaylor1
Modified:
6 years, 4 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Re-enable shared module tests on windows BUG=395796 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290938

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M chrome/browser/extensions/shared_module_apitest.cc View 2 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
elijahtaylor1
PTAL Note: I did nothing to fix the issue with these test failing. Sordid history: ...
6 years, 4 months ago (2014-08-20 20:12:54 UTC) #1
Yoyo Zhou
LGTM
6 years, 4 months ago (2014-08-20 20:15:21 UTC) #2
elijahtaylor1
The CQ bit was checked by elijahtaylor@chromium.org
6 years, 4 months ago (2014-08-20 20:19:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/elijahtaylor@chromium.org/459243002/20001
6 years, 4 months ago (2014-08-20 20:20:18 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-20 21:50:29 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 22:52:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (20001) as 290938

Powered by Google App Engine
This is Rietveld 408576698