Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: chrome/browser/extensions/shared_module_apitest.cc

Issue 459243002: Re-enable shared module tests on windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_apitest.h" 5 #include "chrome/browser/extensions/extension_apitest.h"
6 #include "chrome/browser/extensions/extension_test_message_listener.h" 6 #include "chrome/browser/extensions/extension_test_message_listener.h"
7 7
8 using extensions::Extension; 8 using extensions::Extension;
9 9
10 // NB: We use LoadExtension instead of InstallExtension for shared modules so 10 // NB: We use LoadExtension instead of InstallExtension for shared modules so
11 // the public-keys in their manifests are used to generate the extension ID, so 11 // the public-keys in their manifests are used to generate the extension ID, so
12 // it can be imported correctly. We use InstallExtension otherwise so the loads 12 // it can be imported correctly. We use InstallExtension otherwise so the loads
13 // happen through the CRX installer which validates imports. 13 // happen through the CRX installer which validates imports.
14 14
15 #if defined(OS_WIN) 15 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, SharedModule) {
16 // Timing out on Win7 Tests bot. See http://crbug.com/395796 .
17 #define MAYBE_SharedModule DISABLED_SharedModule
18 #else
19 #define MAYBE_SharedModule SharedModule
20 #endif
21 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_SharedModule) {
22 // import_pass depends on this shared module. 16 // import_pass depends on this shared module.
23 ASSERT_TRUE(LoadExtension( 17 ASSERT_TRUE(LoadExtension(
24 test_data_dir_.AppendASCII("shared_module").AppendASCII("shared"))); 18 test_data_dir_.AppendASCII("shared_module").AppendASCII("shared")));
25 19
26 EXPECT_TRUE(RunExtensionTest("shared_module/import_pass")); 20 EXPECT_TRUE(RunExtensionTest("shared_module/import_pass"));
27 21
28 EXPECT_FALSE(InstallExtension( 22 EXPECT_FALSE(InstallExtension(
29 test_data_dir_.AppendASCII("shared_module") 23 test_data_dir_.AppendASCII("shared_module")
30 .AppendASCII("import_wrong_version"), 0)); 24 .AppendASCII("import_wrong_version"), 0));
31 EXPECT_FALSE(InstallExtension( 25 EXPECT_FALSE(InstallExtension(
32 test_data_dir_.AppendASCII("shared_module") 26 test_data_dir_.AppendASCII("shared_module")
33 .AppendASCII("import_non_existent"), 0)); 27 .AppendASCII("import_non_existent"), 0));
34 } 28 }
35 29
36 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, SharedModuleWhitelist) { 30 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, SharedModuleWhitelist) {
37 ASSERT_TRUE(LoadExtension( 31 ASSERT_TRUE(LoadExtension(
38 test_data_dir_.AppendASCII("shared_module") 32 test_data_dir_.AppendASCII("shared_module")
39 .AppendASCII("shared_whitelist"))); 33 .AppendASCII("shared_whitelist")));
40 34
41 EXPECT_FALSE(InstallExtension( 35 EXPECT_FALSE(InstallExtension(
42 test_data_dir_.AppendASCII("shared_module") 36 test_data_dir_.AppendASCII("shared_module")
43 .AppendASCII("import_not_in_whitelist"), 0)); 37 .AppendASCII("import_not_in_whitelist"), 0));
44 } 38 }
45 39
46 #if defined(OS_WIN) 40 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, SharedModuleInstallEvent) {
47 // Timing out on Win7 Tests bot. See http://crbug.com/395796 .
48 #define MAYBE_SharedModuleInstallEvent DISALBED_SharedModuleInstallEvent
49 #else
50 #define MAYBE_SharedModuleInstallEvent SharedModuleInstallEvent
51 #endif
52 IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_SharedModuleInstallEvent) {
53 ExtensionTestMessageListener listener1("ready", false); 41 ExtensionTestMessageListener listener1("ready", false);
54 42
55 const Extension* extension = LoadExtension( 43 const Extension* extension = LoadExtension(
56 test_data_dir_.AppendASCII("shared_module").AppendASCII("shared")); 44 test_data_dir_.AppendASCII("shared_module").AppendASCII("shared"));
57 ASSERT_TRUE(extension); 45 ASSERT_TRUE(extension);
58 ASSERT_TRUE(InstallExtension( 46 ASSERT_TRUE(InstallExtension(
59 test_data_dir_.AppendASCII("shared_module").AppendASCII("import_pass"), 47 test_data_dir_.AppendASCII("shared_module").AppendASCII("import_pass"),
60 1)); 48 1));
61 49
62 EXPECT_TRUE(listener1.WaitUntilSatisfied()); 50 EXPECT_TRUE(listener1.WaitUntilSatisfied());
63 51
64 ExtensionTestMessageListener listener2("shared_module_updated", false); 52 ExtensionTestMessageListener listener2("shared_module_updated", false);
65 ReloadExtension(extension->id()); 53 ReloadExtension(extension->id());
66 54
67 EXPECT_TRUE(listener2.WaitUntilSatisfied()); 55 EXPECT_TRUE(listener2.WaitUntilSatisfied());
68 } 56 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698