Issue 45913002: pkg/unittest: Capture stackTrace in all failure cases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 45913002: pkg/unittest: Capture stackTrace in all failure cases (Closed)

Created:
7 years, 1 month ago by kevmoo-old

Modified:
7 years, 1 month ago

Reviewers:
Siggi Cherem (dart-lang), gram

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/unittest: Capture stackTrace in all failure cases Not just when catching an Error removed use of deprecated getAttachedStackTrace Cleaned up dart2js warning about checking 'is double' - just check for num

Patch Set 1 #

Patch Set 2 : upload fail the first time #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -11 lines)			Patch
	M	pkg/unittest/lib/src/numeric_matchers.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	pkg/unittest/lib/src/test_case.dart	View		1 chunk	+1 line, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kevmoo-old

This eliminates 98% of my annoyance with Error vs Exception

7 years, 1 month ago (2013-10-25 22:43:14 UTC) #1

ahe

Sounds reasonable, but I think Graham is more familiar with this code.

7 years, 1 month ago (2013-10-28 10:23:43 UTC) #2

kevmoo-old

On 2013/10/28 10:23:43, ahe wrote: > Sounds reasonable, but I think Graham is more familiar ...

7 years, 1 month ago (2013-10-28 14:50:37 UTC) #3

Siggi Cherem (dart-lang)

7 years, 1 month ago (2013-10-28 17:30:44 UTC) #4

Message was sent while issue was closed.

haha - awesome. Thanks again Kevin.

FWIW - lgtm! ;-)

Expand Messages | Collapse Messages