pkg/unittest/lib/src/numeric_matchers.dart - Issue 45913002: pkg/unittest: Capture stackTrace in all failure cases

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/unittest/lib/src/numeric_matchers.dart

Issue 45913002: pkg/unittest: Capture stackTrace in all failure cases (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: upload fail the first time Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/unittest/lib/src/numeric_matchers.dart

diff --git a/pkg/unittest/lib/src/numeric_matchers.dart b/pkg/unittest/lib/src/numeric_matchers.dart

index d040efb24a5a43116e4e931e73dc619361c68e39..f733fa6bbf83f1384cb335b2d61b7ebf002b0a43 100644

--- a/pkg/unittest/lib/src/numeric_matchers.dart

+++ b/pkg/unittest/lib/src/numeric_matchers.dart

@@ -73,8 +73,8 @@ const Matcher isNonNegative =

const _OrderingComparison(0, true, false, true,

'a non-negative value', false);

-bool _isNumeric(value) {

- return value is int || value is double;

+bool _isNumeric(Object value) {

+ return value is num;

}

class _OrderingComparison extends Matcher {

« no previous file with comments | « no previous file | pkg/unittest/lib/src/test_case.dart » ('j') | no next file with comments »