Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: chrome/browser/password_manager/native_backend_gnome_x_unittest.cc

Issue 459103005: Introduce new PasswordForm attributes for Credential Management API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Mike's comment Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
diff --git a/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc b/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
index 5463b048d89e1d571d40fd6ca8b7e45b9386591d..5de4972a4ada113ae85dc5d24083af4f1358e610 100644
--- a/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
+++ b/chrome/browser/password_manager/native_backend_gnome_x_unittest.cc
@@ -306,6 +306,10 @@ void CheckPasswordChanges(const PasswordStoreChangeList& expected_list,
EXPECT_EQ(expected.times_used, actual.times_used);
EXPECT_EQ(expected.scheme, actual.scheme);
EXPECT_EQ(expected.date_synced, actual.date_synced);
+ EXPECT_EQ(expected.display_name, actual.display_name);
+ EXPECT_EQ(expected.avatar_url, actual.avatar_url);
+ EXPECT_EQ(expected.federation_url, actual.federation_url);
+ EXPECT_EQ(expected.is_zero_click, actual.is_zero_click);
}
}
@@ -350,6 +354,10 @@ class NativeBackendGnomeTest : public testing::Test {
form_google_.type = PasswordForm::TYPE_GENERATED;
form_google_.date_created = base::Time::Now();
form_google_.date_synced = base::Time::Now();
+ form_google_.display_name = UTF8ToUTF16("Joe Schmoe");
+ form_google_.avatar_url = GURL("http://www.google.com/avatar");
+ form_google_.federation_url = GURL("http://www.google.com/federation_url");
+ form_google_.is_zero_click = true;
form_facebook_.origin = GURL("http://www.facebook.com/");
form_facebook_.action = GURL("http://www.facebook.com/login");
@@ -361,6 +369,10 @@ class NativeBackendGnomeTest : public testing::Test {
form_facebook_.signon_realm = "http://www.facebook.com/";
form_facebook_.date_created = base::Time::Now();
form_facebook_.date_synced = base::Time::Now();
+ form_facebook_.display_name = UTF8ToUTF16("Joe Schmoe");
+ form_facebook_.avatar_url = GURL("http://www.facebook.com/avatar");
+ form_facebook_.federation_url = GURL("http://www.facebook.com/federation");
+ form_facebook_.is_zero_click = true;
form_isc_.origin = GURL("http://www.isc.org/");
form_isc_.action = GURL("http://www.isc.org/auth");
@@ -434,7 +446,7 @@ class NativeBackendGnomeTest : public testing::Test {
EXPECT_EQ("login", item->keyring);
EXPECT_EQ(form.origin.spec(), item->display_name);
EXPECT_EQ(UTF16ToUTF8(form.password_value), item->password);
- EXPECT_EQ(16u, item->attributes.size());
+ EXPECT_EQ(20u, item->attributes.size());
CheckStringAttribute(item, "origin_url", form.origin.spec());
CheckStringAttribute(item, "action_url", form.action.spec());
CheckStringAttribute(item, "username_element",
@@ -453,9 +465,13 @@ class NativeBackendGnomeTest : public testing::Test {
CheckUint32Attribute(item, "type", form.type);
CheckUint32Attribute(item, "times_used", form.times_used);
CheckUint32Attribute(item, "scheme", form.scheme);
- CheckStringAttribute(item, "application", app_string);
CheckStringAttribute(item, "date_synced", base::Int64ToString(
form.date_synced.ToInternalValue()));
+ CheckStringAttribute(item, "display_name", UTF16ToUTF8(form.display_name));
+ CheckStringAttribute(item, "avatar_url", form.avatar_url.spec());
+ CheckStringAttribute(item, "federation_url", form.federation_url.spec());
+ CheckUint32Attribute(item, "is_zero_click", form.is_zero_click);
+ CheckStringAttribute(item, "application", app_string);
}
// Saves |credentials| and then gets logins matching |url| and |scheme|.
« no previous file with comments | « chrome/browser/password_manager/native_backend_gnome_x.cc ('k') | chrome/browser/password_manager/native_backend_kwallet_x.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698