Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2141)

Unified Diff: chrome/browser/password_manager/native_backend_gnome_x.cc

Issue 459103005: Introduce new PasswordForm attributes for Credential Management API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Mike's comment Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/native_backend_gnome_x_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/native_backend_gnome_x.cc
diff --git a/chrome/browser/password_manager/native_backend_gnome_x.cc b/chrome/browser/password_manager/native_backend_gnome_x.cc
index 8a8c656543ae9f98494ab250f49d1711d7cd4c4a..5d288b9f591bf9aa1c685f972e5a813df4f067b4 100644
--- a/chrome/browser/password_manager/native_backend_gnome_x.cc
+++ b/chrome/browser/password_manager/native_backend_gnome_x.cc
@@ -140,6 +140,10 @@ scoped_ptr<PasswordForm> FormFromAttributes(GnomeKeyringAttributeList* attrs) {
int64 date_synced = 0;
base::StringToInt64(string_attr_map["date_synced"], &date_synced);
form->date_synced = base::Time::FromInternalValue(date_synced);
+ form->display_name = UTF8ToUTF16(string_attr_map["display_name"]);
+ form->avatar_url = GURL(string_attr_map["avatar_url"]);
+ form->federation_url = GURL(string_attr_map["federation_url"]);
+ form->is_zero_click = uint_attr_map["is_zero_click"];
return form.Pass();
}
@@ -222,6 +226,10 @@ const GnomeKeyringPasswordSchema kGnomeSchema = {
{ "type", GNOME_KEYRING_ATTRIBUTE_TYPE_UINT32 },
{ "times_used", GNOME_KEYRING_ATTRIBUTE_TYPE_UINT32 },
{ "date_synced", GNOME_KEYRING_ATTRIBUTE_TYPE_STRING },
+ { "display_name", GNOME_KEYRING_ATTRIBUTE_TYPE_STRING },
+ { "avatar_url", GNOME_KEYRING_ATTRIBUTE_TYPE_STRING },
+ { "federation_url", GNOME_KEYRING_ATTRIBUTE_TYPE_STRING },
+ { "is_zero_click", GNOME_KEYRING_ATTRIBUTE_TYPE_UINT32 },
// This field is always "chrome" so that we can search for it.
{ "application", GNOME_KEYRING_ATTRIBUTE_TYPE_STRING },
{ NULL }
@@ -340,6 +348,10 @@ void GKRMethod::AddLogin(const PasswordForm& form, const char* app_string) {
"times_used", form.times_used,
"scheme", form.scheme,
"date_synced", base::Int64ToString(date_synced).c_str(),
+ "display_name", UTF16ToUTF8(form.display_name).c_str(),
+ "avatar_url", form.avatar_url.spec().c_str(),
+ "federation_url", form.federation_url.spec().c_str(),
+ "is_zero_click", form.is_zero_click,
"application", app_string,
NULL);
}
« no previous file with comments | « no previous file | chrome/browser/password_manager/native_backend_gnome_x_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698