Change GR_COMPRESS_ALPHA_MASK from compile-time flag to run-time flag

Change GR_COMPRESS_ALPHA_MASK from compile-time flag to run-time. We do this by introducing an Options struct to be passed to a GrContext on creation.

Committed: https://skia.googlesource.com/skia/+/9c6d4d744a9e0375d0e7d7a7b19558f5259fc3c3

[bsalomon, 2014-08-11 19:00:47]

https://codereview.chromium.org/459033002/diff/20001/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/459033002/diff/20001/include/gpu/GrContext.h#...
include/gpu/GrContext.h:54: bool fDrawPathToCompressedTexture;
Should we label this field experimental or something? I imagine in the future we
will either always use it or not based on what the testing looks like.

https://codereview.chromium.org/459033002/diff/20001/include/gpu/GrContext.h#...
include/gpu/GrContext.h:336: bool supportsDrawPathToCompressedTexture() const;
Does this need to be public? It feels like we're exposing an implementation
detail that most users shouldn't care about.

[krajcevski, 2014-08-11 19:09:55]

https://codereview.chromium.org/459033002/diff/20001/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/459033002/diff/20001/include/gpu/GrContext.h#...
include/gpu/GrContext.h:54: bool fDrawPathToCompressedTexture;
On 2014/08/11 19:00:47, bsalomon wrote:
> Should we label this field experimental or something? I imagine in the future
we
> will either always use it or not based on what the testing looks like.

Done.

https://codereview.chromium.org/459033002/diff/20001/include/gpu/GrContext.h#...
include/gpu/GrContext.h:336: bool supportsDrawPathToCompressedTexture() const;
On 2014/08/11 19:00:47, bsalomon wrote:
> Does this need to be public? It feels like we're exposing an implementation
> detail that most users shouldn't care about.

I moved it to the "for internal use only" section.

[robertphillips, 2014-08-11 19:22:20]

https://codereview.chromium.org/459033002/diff/40001/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/459033002/diff/40001/include/gpu/GrContext.h#...
include/gpu/GrContext.h:956: */
drawPathsToCompressedTextures ?
compressCoverageMasks ?

https://codereview.chromium.org/459033002/diff/40001/include/gpu/GrContext.h#...
include/gpu/GrContext.h:1005: int                            
fMaxTextureSizeOverride;
Options fOptions; ?

https://codereview.chromium.org/459033002/diff/40001/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/459033002/diff/40001/src/gpu/GrContext.cpp#ne...
src/gpu/GrContext.cpp:86: 
Can we just have this in the header?

[bsalomon, 2014-08-11 19:42:42]

https://codereview.chromium.org/459033002/diff/40001/src/gpu/GrSWMaskHelper.cpp
File src/gpu/GrSWMaskHelper.cpp (right):

https://codereview.chromium.org/459033002/diff/40001/src/gpu/GrSWMaskHelper.c...
src/gpu/GrSWMaskHelper.cpp:172: if
(fContext->supportsDrawPathToCompressedTexture() &&
Could we just expose the options struct here rather than have a special function
for this preference?

[krajcevski, 2014-08-11 20:01:34]

https://codereview.chromium.org/459033002/diff/40001/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/459033002/diff/40001/include/gpu/GrContext.h#...
include/gpu/GrContext.h:956: */
On 2014/08/11 19:22:20, robertphillips wrote:
> drawPathsToCompressedTextures ?
> compressCoverageMasks ?

Done.

https://codereview.chromium.org/459033002/diff/40001/include/gpu/GrContext.h#...
include/gpu/GrContext.h:1005: int                            
fMaxTextureSizeOverride;
On 2014/08/11 19:22:20, robertphillips wrote:
> Options fOptions; ?

Done.

https://codereview.chromium.org/459033002/diff/40001/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.chromium.org/459033002/diff/40001/src/gpu/GrContext.cpp#ne...
src/gpu/GrContext.cpp:86: 
On 2014/08/11 19:22:20, robertphillips wrote:
> Can we just have this in the header?

Done.

https://codereview.chromium.org/459033002/diff/40001/src/gpu/GrSWMaskHelper.cpp
File src/gpu/GrSWMaskHelper.cpp (right):

https://codereview.chromium.org/459033002/diff/40001/src/gpu/GrSWMaskHelper.c...
src/gpu/GrSWMaskHelper.cpp:172: if
(fContext->supportsDrawPathToCompressedTexture() &&
On 2014/08/11 19:42:42, bsalomon wrote:
> Could we just expose the options struct here rather than have a special
function
> for this preference?

Done.

[bsalomon, 2014-08-11 20:51:32]

lgtm if comment is updated

https://codereview.chromium.org/459033002/diff/60001/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/459033002/diff/60001/include/gpu/GrContext.h#...
include/gpu/GrContext.h:954: *  This returns true if the underlying graphics
device and system is
update comment?

[robertphillips, 2014-08-11 21:36:32]

https://codereview.chromium.org/459033002/diff/80001/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/459033002/diff/80001/include/gpu/GrContext.h#...
include/gpu/GrContext.h:52: struct Options {
For now we can just have this all on one line.

https://codereview.chromium.org/459033002/diff/80001/include/gpu/GrContext.h#...
include/gpu/GrContext.h:953: /**
"a copy of the GrContext::Options that was passed" ?

[krajcevski, 2014-08-12 14:17:50]

https://codereview.chromium.org/459033002/diff/80001/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/459033002/diff/80001/include/gpu/GrContext.h#...
include/gpu/GrContext.h:52: struct Options {
On 2014/08/11 21:36:31, robertphillips wrote:
> For now we can just have this all on one line.

Done.

https://codereview.chromium.org/459033002/diff/80001/include/gpu/GrContext.h#...
include/gpu/GrContext.h:953: /**
On 2014/08/11 21:36:31, robertphillips wrote:
> "a copy of the GrContext::Options that was passed" ?

Done.

[krajcevski, 2014-08-12 14:17:53]

The CQ bit was checked by krajcevski@google.com

[commit-bot: I haz the power, 2014-08-12 14:18:24]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/krajcevski@google.com/459033002/100001

[commit-bot: I haz the power, 2014-08-12 14:26:30]

Change committed as 9c6d4d744a9e0375d0e7d7a7b19558f5259fc3c3