Move app list search result icon sizes to app_list_constants.

chrome/browser/ui/app_list/search/app_result.cc

Index: chrome/browser/ui/app_list/search/app_result.cc
diff --git a/chrome/browser/ui/app_list/search/app_result.cc b/chrome/browser/ui/app_list/search/app_result.cc
index 578f6f60987eefb99fb656aac8d078c432c31d16..706dc5877d1168441eecb9a9f38eb7e41797011e 100644
--- a/chrome/browser/ui/app_list/search/app_result.cc
+++ b/chrome/browser/ui/app_list/search/app_result.cc
@@ -47,14 +47,13 @@ AppResult::AppResult(Profile* profile,
 
   is_platform_app_ = extension->is_platform_app();
 
-  icon_.reset(new extensions::IconImage(
-      profile_,
-      extension,
-      extensions::IconsInfo::GetIcons(extension),
-      display_type() == DISPLAY_TILE ? extension_misc::EXTENSION_ICON_MEDIUM
-                                     : extension_misc::EXTENSION_ICON_SMALL,
-      extensions::util::GetDefaultAppIcon(),
-      this));
+  icon_.reset(
+      new extensions::IconImage(profile_,
+                                extension,
+                                extensions::IconsInfo::GetIcons(extension),
+                                GetPreferredIconSize(),

[Matt Giuca, 2014/08/12 06:43:24]

So we're explicitly forking these values away from EXTENSION_ICON_SMALL and
EXTENSION_ICON_MEDIUM. (I checked; they are the same size.) Is that something we
want? Would there be a problem if kListIconSize and kTileIconSize were to become
different to EXTENSION_ICON_SMALL and EXTENSION_ICON_MEDIUM, respectively?

[calamity, 2014/08/13 06:03:17]

Tried it. It didn't seem to be a problem. Semantically, it's fine as these are
search result preferred sizes.

[Matt Giuca, 2014/08/13 06:15:25]

Acknowledged.

+                                extensions::util::GetDefaultAppIcon(),
+                                this));
   UpdateIcon();
 
   StartObservingExtensionRegistry();