Move app list search result icon sizes to app_list_constants.

chrome/browser/ui/app_list/search/app_result.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/app_list/search/app_result.h"
 
 #include "base/time/time.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_util.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 29 matching lines @@
   if (app_list::switches::IsExperimentalAppListEnabled())
     set_display_type(DISPLAY_TILE);
 
   const extensions::Extension* extension =
       extensions::ExtensionSystem::Get(profile_)->extension_service()
           ->GetInstalledExtension(app_id_);
   DCHECK(extension);
 
   is_platform_app_ = extension->is_platform_app();
 
-  icon_.reset(new extensions::IconImage(
-      profile_,
-      extension,
-      extensions::IconsInfo::GetIcons(extension),
-      display_type() == DISPLAY_TILE ? extension_misc::EXTENSION_ICON_MEDIUM
-                                     : extension_misc::EXTENSION_ICON_SMALL,
-      extensions::util::GetDefaultAppIcon(),
-      this));
+  icon_.reset(
+      new extensions::IconImage(profile_,
+                                extension,
+                                extensions::IconsInfo::GetIcons(extension),
+                                GetPreferredIconSize(),

[Matt Giuca, 2014/08/12 06:43:24]

So we're explicitly forking these values away from EXTENSION_ICON_SMALL and
EXTENSION_ICON_MEDIUM. (I checked; they are the same size.) Is that something we
want? Would there be a problem if kListIconSize and kTileIconSize were to become
different to EXTENSION_ICON_SMALL and EXTENSION_ICON_MEDIUM, respectively?

[calamity, 2014/08/13 06:03:17]

Tried it. It didn't seem to be a problem. Semantically, it's fine as these are
search result preferred sizes.

[Matt Giuca, 2014/08/13 06:15:25]

Acknowledged.

+                                extensions::util::GetDefaultAppIcon(),
+                                this));
   UpdateIcon();
 
   StartObservingExtensionRegistry();
 }
 
 AppResult::~AppResult() {
   StopObservingExtensionRegistry();
 }
 
 void AppResult::UpdateFromMatch(const TokenizedString& title,
@@ skipping 147 matching lines @@
 
   NotifyItemUninstalled();
 }
 
 void AppResult::OnShutdown(extensions::ExtensionRegistry* registry) {
   DCHECK_EQ(extension_registry_, registry);
   StopObservingExtensionRegistry();
 }
 
 }  // namespace app_list