Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1789)

Issue 458953002: Remove custom getters for File.lastModified{Date} (Closed)

Created:
6 years, 4 months ago by sof
Modified:
6 years, 4 months ago
Reviewers:
haraken, kinuko
CC:
blink-reviews, arv+blink, tzik, nhiroki, abarth-chromium, blink-reviews-bindings_chromium.org, Inactive, kinuko+fileapi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove custom getters for File.lastModified{Date} No particular need for these to be custom, so turned into File accessors instead. Also drop a runtime feature check for FileConstructor; it is now stable. R=haraken BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179944

Patch Set 1 #

Patch Set 2 : Tidy comment #

Total comments: 2

Patch Set 3 : Preserve comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -40 lines) Patch
M Source/bindings/core/v8/custom/V8FileCustom.cpp View 3 chunks +0 lines, -36 lines 0 comments Download
M Source/core/fileapi/File.h View 1 2 chunks +10 lines, -1 line 0 comments Download
M Source/core/fileapi/File.cpp View 1 2 2 chunks +27 lines, -1 line 0 comments Download
M Source/core/fileapi/File.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
sof
Please take a look.
6 years, 4 months ago (2014-08-11 10:23:00 UTC) #1
haraken
LGTM https://codereview.chromium.org/458953002/diff/20001/Source/bindings/core/v8/custom/V8FileCustom.cpp File Source/bindings/core/v8/custom/V8FileCustom.cpp (left): https://codereview.chromium.org/458953002/diff/20001/Source/bindings/core/v8/custom/V8FileCustom.cpp#oldcode96 Source/bindings/core/v8/custom/V8FileCustom.cpp:96: // current time when the last modification time ...
6 years, 4 months ago (2014-08-11 10:39:43 UTC) #2
sof
https://codereview.chromium.org/458953002/diff/20001/Source/bindings/core/v8/custom/V8FileCustom.cpp File Source/bindings/core/v8/custom/V8FileCustom.cpp (left): https://codereview.chromium.org/458953002/diff/20001/Source/bindings/core/v8/custom/V8FileCustom.cpp#oldcode96 Source/bindings/core/v8/custom/V8FileCustom.cpp:96: // current time when the last modification time is ...
6 years, 4 months ago (2014-08-11 10:58:08 UTC) #3
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-11 10:58:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/458953002/40001
6 years, 4 months ago (2014-08-11 10:59:51 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-11 11:56:55 UTC) #6
sof
The CQ bit was unchecked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-11 12:29:59 UTC) #7
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 4 months ago (2014-08-11 12:30:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/458953002/40001
6 years, 4 months ago (2014-08-11 12:31:23 UTC) #9
kinuko
lgtm CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/458953002/40001 https://codereview.chromium.org/458953002/ To unsubscribe from this ...
6 years, 4 months ago (2014-08-11 12:58:28 UTC) #10
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 13:04:00 UTC) #11
Message was sent while issue was closed.
Change committed as 179944

Powered by Google App Engine
This is Rietveld 408576698