Remove custom getters for File.lastModified{Date}

Source/bindings/core/v8/custom/V8FileCustom.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 15 matching lines @@
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "bindings/core/v8/V8File.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/custom/V8BlobCustomHelpers.h"
-#include "platform/RuntimeEnabledFeatures.h"
 
 namespace blink {
 
 void V8File::constructorCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     ExceptionState exceptionState(ExceptionState::ConstructionContext, "File", info.Holder(), info.GetIsolate());
 
-    if (!RuntimeEnabledFeatures::fileConstructorEnabled()) {
-        exceptionState.throwTypeError("Illegal constructor");
-        exceptionState.throwIfNeeded();
-        return;
-    }
-
     if (info.Length() < 2) {
         exceptionState.throwTypeError(ExceptionMessages::notEnoughArguments(2, info.Length()));
         exceptionState.throwIfNeeded();
         return;
     }
 
     // FIXME: handle sequences based on ES6 @@iterator, see http://crbug.com/393866
     if (!info[0]->IsArray()) {
         exceptionState.throwTypeError(ExceptionMessages::argumentNullOrIncorrectType(1, "Array"));
         exceptionState.throwIfNeeded();
@@ skipping 22 matching lines @@
     blobData->setContentType(properties.contentType());
     v8::Local<v8::Object> blobParts = v8::Local<v8::Object>::Cast(info[0]);
     if (!V8BlobCustomHelpers::processBlobParts(blobParts, properties.normalizeLineEndingsToNative(), *blobData, info.GetIsolate()))
         return;
 
     long long fileSize = blobData->length();
     RefPtrWillBeRawPtr<File> file = File::create(fileName, properties.lastModified(), BlobDataHandle::create(blobData.release(), fileSize));
     v8SetReturnValue(info, file.release());
 }
 
-void V8File::lastModifiedDateAttributeGetterCustom(const v8::PropertyCallbackInfo<v8::Value>& info)
-{
-    // The auto-generated getters return null when the method in the underlying
-    // implementation returns NaN. The File API says we should return the
-    // current time when the last modification time is unknown.

[haraken, 2014/08/11 10:39:42]

Would you keep this comment somewhere? There was a lot of discussion about this
behavior once before.

[sof, 2014/08/11 10:58:08]

Yes, there was. Moved (shortened) comment into the getters.

-    // Section 7.2 of the File API spec. http://dev.w3.org/2006/webapi/FileAPI/
-
-    File* file = V8File::toNative(info.Holder());
-    double lastModified = file->lastModifiedDate();
-    if (!isValidFileTime(lastModified))
-        lastModified = currentTimeMS();
-
-    // lastModifiedDate returns a Date instance.
-    // http://www.w3.org/TR/FileAPI/#file-attrs
-    v8SetReturnValue(info, v8::Date::New(info.GetIsolate(), lastModified));
-}
-
-void V8File::lastModifiedAttributeGetterCustom(const v8::PropertyCallbackInfo<v8::Value>& info)
-{
-    File* file = V8File::toNative(info.Holder());
-    double lastModified = file->lastModifiedDate();
-    if (!isValidFileTime(lastModified))
-        lastModified = currentTimeMS();
-
-    // lastModified returns a number, not a Date instance.
-    // http://dev.w3.org/2006/webapi/FileAPI/#file-attrs
-    v8SetReturnValue(info, floor(lastModified));
-}
-
 } // namespace blink