Issue 458873002: Enable signed/unsigned warning in libaddressinput unit tests on Windows.

Issue 458873002: Enable signed/unsigned warning in libaddressinput unit tests on Windows. (Closed)

Created:
6 years, 4 months ago by please use gerrit instead

Modified:
6 years, 4 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Enable signed/unsigned warning in libaddressinput unit tests on Windows. TBR=estade@chromium.org BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289070

Patch Set 2 : Rebase. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -12 lines)			Patch
M	DEPS	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/libaddressinput/README.chromium	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	third_party/libaddressinput/libaddressinput.gyp	View		1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

please use gerrit instead

The CQ bit was checked by rouslan@chromium.org

6 years, 4 months ago (2014-08-12 16:39:20 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/458873002/1

6 years, 4 months ago (2014-08-12 16:42:37 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...

6 years, 4 months ago (2014-08-12 17:11:58 UTC) #5

please use gerrit instead

The CQ bit was unchecked by rouslan@chromium.org

6 years, 4 months ago (2014-08-12 17:13:45 UTC) #6

please use gerrit instead

The CQ bit was checked by rouslan@chromium.org

6 years, 4 months ago (2014-08-12 17:14:27 UTC) #7

commit-bot: I haz the power

Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/3678) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/3355) win8_chromium_rel ...

6 years, 4 months ago (2014-08-12 17:20:00 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/458873002/20001

6 years, 4 months ago (2014-08-12 17:20:46 UTC) #9

Message was sent while issue was closed.

Change committed as 289070

Expand Messages | Collapse Messages