third_party/libaddressinput/libaddressinput.gyp - Issue 458873002: Enable signed/unsigned warning in libaddressinput unit tests on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libaddressinput/libaddressinput.gyp

Issue 458873002: Enable signed/unsigned warning in libaddressinput unit tests on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/libaddressinput/libaddressinput.gyp

diff --git a/third_party/libaddressinput/libaddressinput.gyp b/third_party/libaddressinput/libaddressinput.gyp

index 17524064c0eeb54f6543a9e761e2d4ae54ec2118..3fca8560e5c367fb9beccd97580cce2da950cee9 100644

--- a/third_party/libaddressinput/libaddressinput.gyp

+++ b/third_party/libaddressinput/libaddressinput.gyp

@@ -144,15 +144,6 @@

'chromium/string_compare_unittest.cc',

'chromium/trie_unittest.cc',

- 'conditions': [

- ['OS=="win"', {

- # TODO(rouslan): Enable signed/unsigned warning after bumping to

- # https://code.google.com/p/libaddressinput/source/detail?r=327

- 'msvs_disabled_warnings': [

- 4018,

- ],

- }],

- ],

'defines': [

'TEST_DATA_DIR="<(libaddressinput_test_data_dir)"',

« no previous file with comments | « third_party/libaddressinput/README.chromium ('k') | no next file » | no next file with comments »