Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 458723002: TestInterfaces to chromium c++ style, rename methods and remove un-used header. (Closed)

Created:
6 years, 4 months ago by Abhishek
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

TestInterfaces to chromium c++ style, rename methods and remove un-used header. Changes: 1) Run clang-format through source and header files. 2) Rename data member variables to use unix_hacker_ style. 3) Rename methods to use CamelCase style. 4) Rename file name to test_interfaces. 5) Rename methods testRunner, eventSender and accessibilityController to GetTestRunner, GetEventSender and GetAccessibilityController respectively. 6) Removed un-used test_interfaces header. BUG=331299 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288768

Patch Set 1 #

Total comments: 8

Patch Set 2 : updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+392 lines, -403 lines) Patch
M content/content_shell.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
D content/shell/renderer/test_runner/TestInterfaces.h View 1 chunk +0 lines, -82 lines 0 comments Download
D content/shell/renderer/test_runner/TestInterfaces.cpp View 1 chunk +0 lines, -203 lines 0 comments Download
M content/shell/renderer/test_runner/WebTestInterfaces.cpp View 1 2 chunks +9 lines, -9 lines 0 comments Download
M content/shell/renderer/test_runner/event_sender.cc View 1 4 chunks +7 lines, -4 lines 0 comments Download
M content/shell/renderer/test_runner/gamepad_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/renderer/test_runner/mock_web_media_stream_center.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/mock_web_midi_accessor.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/mock_webrtc_peer_connection_handler.cc View 1 9 chunks +20 lines, -18 lines 0 comments Download
A content/shell/renderer/test_runner/test_interfaces.h View 1 1 chunk +83 lines, -0 lines 0 comments Download
A content/shell/renderer/test_runner/test_interfaces.cc View 1 1 chunk +184 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M content/shell/renderer/test_runner/web_frame_test_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 1 40 chunks +74 lines, -71 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Abhishek
PTAL!
6 years, 4 months ago (2014-08-09 12:54:23 UTC) #1
jochen (gone - plz use gerrit)
lgtm with nits https://codereview.chromium.org/458723002/diff/1/content/shell/renderer/test_runner/test_interfaces.h File content/shell/renderer/test_runner/test_interfaces.h (right): https://codereview.chromium.org/458723002/diff/1/content/shell/renderer/test_runner/test_interfaces.h#newcode14 content/shell/renderer/test_runner/test_interfaces.h:14: #if defined(__APPLE__) #if defined(OS_MACOSX) https://codereview.chromium.org/458723002/diff/1/content/shell/renderer/test_runner/test_interfaces.h#newcode57 content/shell/renderer/test_runner/test_interfaces.h:57: ...
6 years, 4 months ago (2014-08-11 14:31:59 UTC) #2
Abhishek
All comments are incorporated. PTAL! https://codereview.chromium.org/458723002/diff/1/content/shell/renderer/test_runner/test_interfaces.h File content/shell/renderer/test_runner/test_interfaces.h (right): https://codereview.chromium.org/458723002/diff/1/content/shell/renderer/test_runner/test_interfaces.h#newcode14 content/shell/renderer/test_runner/test_interfaces.h:14: #if defined(__APPLE__) On 2014/08/11 ...
6 years, 4 months ago (2014-08-11 17:00:38 UTC) #3
Abhishek
The CQ bit was checked by abhishek.a21@samsung.com
6 years, 4 months ago (2014-08-11 17:04:05 UTC) #4
Abhishek
The CQ bit was unchecked by abhishek.a21@samsung.com
6 years, 4 months ago (2014-08-11 17:04:25 UTC) #5
Abhishek
The CQ bit was checked by abhishek.a21@samsung.com
6 years, 4 months ago (2014-08-11 17:04:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abhishek.a21@samsung.com/458723002/20001
6 years, 4 months ago (2014-08-11 17:06:46 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 19:48:01 UTC) #8
Message was sent while issue was closed. 
Change committed as 288768

Powered by Google App Engine
This is Rietveld 408576698