Issue 458653002: Update lint and findbugs to use jars instead of class files

Issue 458653002: Update lint and findbugs to use jars instead of class files (Closed)

Created:
6 years, 4 months ago by cjhopman

Modified:
6 years, 4 months ago

Reviewers:
newt (away)

CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Update lint and findbugs to use jars instead of class files Now that this is done, we don't need to leave the class files laying around anymore. So don't. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288971

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Rename to _GetChromeJars #

Patch Set 3 : Add a landmine #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -52 lines)			Patch
M	build/android/gyp/lint.py	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	build/android/lint_action.gypi	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	build/android/push_libraries.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	build/android/pylib/utils/findbugs.py	View	1	2 chunks	+6 lines, -5 lines	0 comments	Download
M	build/get_landmines.py	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	build/java.gypi	View		5 chunks	+19 lines, -19 lines	0 comments	Download
M	build/java_apk.gypi	View		4 chunks	+16 lines, -20 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

newt (away)

lgtm Can we delete the class files now? https://codereview.chromium.org/458653002/diff/20001/build/android/pylib/utils/findbugs.py File build/android/pylib/utils/findbugs.py (right): https://codereview.chromium.org/458653002/diff/20001/build/android/pylib/utils/findbugs.py#newcode69 build/android/pylib/utils/findbugs.py:69: def ...

6 years, 4 months ago (2014-08-11 22:00:11 UTC) #2

cjhopman

I'm adding a landmine. This'll delete all the old .class files from previous builds that ...

6 years, 4 months ago (2014-08-12 02:02:43 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/458653002/60001

6 years, 4 months ago (2014-08-12 02:10:28 UTC) #5

Message was sent while issue was closed.

Change committed as 288971

Expand Messages | Collapse Messages