build/get_landmines.py - Issue 458653002: Update lint and findbugs to use jars instead of class files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/get_landmines.py

Issue 458653002: Update lint and findbugs to use jars instead of class files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a landmine Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/get_landmines.py

diff --git a/build/get_landmines.py b/build/get_landmines.py

index ee7f76af8f5017e990159a225bcc9e1fc75415d9..c9e87734844306b77801f57111a07e1dd8336610 100755

--- a/build/get_landmines.py

+++ b/build/get_landmines.py

@@ -30,8 +30,7 @@ def print_landmines(target):

builder() == 'ninja'):

print 'Need to clobber winja goma due to backend cwd cache fix.'

if platform() == 'android':

- print 'Clobber: To avoid unresolved link errors on Breakpad roll.'

- print 'Clobber: To get rid of generated files in the wrong package.'

+ print 'Clobber: To delete generated class files (we just use jars now).'

if platform() == 'win' and builder() == 'ninja':

print 'Compile on cc_unittests fails due to symbols removed in r185063.'

if platform() == 'linux' and builder() == 'ninja':

« no previous file with comments | « build/android/pylib/utils/findbugs.py ('k') | build/java.gypi » ('j') | no next file with comments »