Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 458613004: Refactor ParseObjectLiteral (Closed)

Created:
6 years, 4 months ago by arv (Not doing code reviews)
Modified:
6 years, 4 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Refactor ParseObjectLiteral This extracts the parsing of the ObjectLiteralProperty into its own function. This is in preparation for adding support for parsing classes. BUG=None LOG=Y R=dslomov@chromium.org, marja@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23249

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -110 lines) Patch
M src/parser.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/preparser.h View 7 chunks +91 lines, -109 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
arv (Not doing code reviews)
This depends on https://codereview.chromium.org/459463002
6 years, 4 months ago (2014-08-11 22:28:47 UTC) #1
marja
lgtm. I was temporarily confused because the boilerplate property checking, function name infering and consuming ...
6 years, 4 months ago (2014-08-12 13:56:37 UTC) #2
arv (Not doing code reviews)
On 2014/08/12 at 13:56:37, marja wrote: > lgtm. I was temporarily confused because the boilerplate ...
6 years, 4 months ago (2014-08-12 14:46:26 UTC) #3
Dmitry Lomov (no reviews)
lgtm
6 years, 4 months ago (2014-08-18 09:03:11 UTC) #4
arv (Not doing code reviews)
6 years, 4 months ago (2014-08-20 15:51:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as 23249 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698