Remove old Aura Gesture Detection Pipeline.

Remove old Aura Gesture Detection Pipeline.

I'll file separate bugs for the additional cleanup this enables.

BUG=332418
Committed: https://crrev.com/61098b92ceb30b427017dc7aadd4fbfa016e045f
Cr-Commit-Position: refs/heads/master@{#291900}

[tdresser, 2014-08-16 00:31:47]

https://codereview.chromium.org/458363002/diff/20001/ui/events/gestures/motio...
File ui/events/gestures/motion_event_aura.cc (right):

https://codereview.chromium.org/458363002/diff/20001/ui/events/gestures/motio...
ui/events/gestures/motion_event_aura.cc:8: #include
"third_party/WebKit/public/web/WebInputEvent.h"
This is a layering violation. I'm still not sure where we should put the maximum
number of touches.

[tdresser, 2014-08-18 16:12:39]

Jared, can you take a look at content/browser/renderer_host?

Also, any thoughts on where we should put the maximum
number of touches?

[jdduke (slow), 2014-08-18 16:32:25]

On 2014/08/18 16:12:39, tdresser wrote:
> Jared, can you take a look at content/browser/renderer_host?
> 
> Also, any thoughts on where we should put the maximum
> number of touches?

content/browser/renderer_host lgtm.

I suppose you could put the max in MotionEvent (somewhere next to
MAX_POINTER_ID)? Then in motion_event.cc static assert that it's equal to
WebTouchEvent::touchesLengthCap?

[tdresser, 2014-08-18 17:22:48]

On 2014/08/18 16:32:25, jdduke wrote:
> On 2014/08/18 16:12:39, tdresser wrote:
> > Jared, can you take a look at content/browser/renderer_host?
> > 
> > Also, any thoughts on where we should put the maximum
> > number of touches?
> 
> content/browser/renderer_host lgtm.
> 
> I suppose you could put the max in MotionEvent (somewhere next to
> MAX_POINTER_ID)? Then in motion_event.cc static assert that it's equal to
> WebTouchEvent::touchesLengthCap?

motion_event.cc can't read WebTouchEvent::touchesLengthCap without adding a new
dependency, which I'm not sure we want to add.

[jdduke (slow), 2014-08-18 17:54:42]

On 2014/08/18 17:22:48, tdresser wrote:
> On 2014/08/18 16:32:25, jdduke wrote:
> > On 2014/08/18 16:12:39, tdresser wrote:
> > > Jared, can you take a look at content/browser/renderer_host?
> > > 
> > > Also, any thoughts on where we should put the maximum
> > > number of touches?
> > 
> > content/browser/renderer_host lgtm.
> > 
> > I suppose you could put the max in MotionEvent (somewhere next to
> > MAX_POINTER_ID)? Then in motion_event.cc static assert that it's equal to
> > WebTouchEvent::touchesLengthCap?
> 
> motion_event.cc can't read WebTouchEvent::touchesLengthCap without adding a
new
> dependency, which I'm not sure we want to add.

OK then, maybe a static assert in content::CreateWebTouchEventFromMotionEvent?

[tdresser, 2014-08-18 18:07:45]

Yeah, that's a reasonable place for it.

Sadrul, could you take a look at ui?

[tdresser, 2014-08-18 19:58:20]

Removing sadrul temporarily, a bunch more cleanup to do...

[tdresser, 2014-08-21 12:27:44]

Sadrul, can you take a look at ui/?

[sadrul, 2014-08-21 18:30:52]

lgtm

https://codereview.chromium.org/458363002/diff/160001/ui/events/gestures/gest...
File ui/events/gestures/gesture_recognizer_impl.cc (right):

https://codereview.chromium.org/458363002/diff/160001/ui/events/gestures/gest...
ui/events/gestures/gesture_recognizer_impl.cc:124: return NULL;
Remove else. (or 'return <> ? <> : <>;')

[sadrul, 2014-08-21 18:31:23]

nit: Make sure to update the CL description (e.g. remove 'WIP') before landing.

[tdresser, 2014-08-21 20:27:36]

ananta, can you take a look at the two line change in:
win8/metro_driver/chrome_app_view_ash.cc?

https://codereview.chromium.org/458363002/diff/160001/ui/events/gestures/gest...
File ui/events/gestures/gesture_recognizer_impl.cc (right):

https://codereview.chromium.org/458363002/diff/160001/ui/events/gestures/gest...
ui/events/gestures/gesture_recognizer_impl.cc:124: return NULL;
On 2014/08/21 18:30:52, sadrul wrote:
> Remove else. (or 'return <> ? <> : <>;')

Done.

[ananta, 2014-08-25 22:54:58]

chrome_app_view_ash.cc changes lgtm

[tdresser, 2014-08-26 12:06:25]

The CQ bit was checked by tdresser@chromium.org

[commit-bot: I haz the power, 2014-08-26 12:06:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tdresser@chromium.org/458363002/180001

[commit-bot: I haz the power, 2014-08-26 13:11:55]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-26 13:51:41]

Committed patchset #10 (180001) as d23d5ff72dac54120d6ecea18fb08a035c14dd2f

[commit-bot: I haz the power, 2014-09-10 02:42:43]

Patchset 10 (id:??) landed as
https://crrev.com/61098b92ceb30b427017dc7aadd4fbfa016e045f
Cr-Commit-Position: refs/heads/master@{#291900}