Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 458343003: Revert of base: Introduce an explicit call for reducing emulated discardable memory usage. (Closed)

Created:
6 years, 4 months ago by tapted
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, gavinp+memory_chromium.org, jam, chrome-apps-syd-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of base: Introduce an explicit call for reducing emulated discardable memory usage. (https://codereview.chromium.org/448173002/) Reason for revert: tree-closer content_browsertests failing on Linux Chromium OS ASan LSan Tests (1) test RenderThreadImplBrowserTest.EmulatedDiscardableMemoryDiscardedWhenWidgetsHidden failing since http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/2501 Error: LeakSanitizer: detected memory leaks (Various Indirect leaks). .. SUMMARY: AddressSanitizer: 19178 byte(s) leaked in 34 allocation(s). Original issue's description: > base: Introduce an explicit call for reducing emulated discardable memory usage. > > This removes the use of memory pressure signals from discardable memory > system and instead introduces an explicit call for reducing emulated > discardable memory that the renderer can call when all widgets are hidden > until we have a better mechanism in place. > > BUG=398087 > TEST=base_unittests,content_browsertests > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288793 TBR=jochen@chromium.org,mark@chromium.org,reveman@chromium.org NOTREECHECKS=true NOTRY=true BUG=398087 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288913

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -98 lines) Patch
M base/memory/discardable_memory.h View 1 chunk +8 lines, -0 lines 0 comments Download
M base/memory/discardable_memory_android.cc View 2 chunks +14 lines, -1 line 0 comments Download
M base/memory/discardable_memory_emulated.h View 1 chunk +2 lines, -5 lines 0 comments Download
M base/memory/discardable_memory_emulated.cc View 2 chunks +11 lines, -5 lines 0 comments Download
M base/memory/discardable_memory_linux.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M base/memory/discardable_memory_mac.cc View 2 chunks +15 lines, -1 line 0 comments Download
M base/memory/discardable_memory_manager.h View 6 chunks +32 lines, -4 lines 0 comments Download
M base/memory/discardable_memory_manager.cc View 5 chunks +50 lines, -6 lines 0 comments Download
M base/memory/discardable_memory_manager_unittest.cc View 11 chunks +28 lines, -13 lines 0 comments Download
M base/memory/discardable_memory_unittest.cc View 3 chunks +9 lines, -1 line 0 comments Download
M base/memory/discardable_memory_win.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 4 chunks +4 lines, -10 lines 0 comments Download
M content/renderer/render_thread_impl_browsertest.cc View 2 chunks +0 lines, -52 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tapted
Created Revert of base: Introduce an explicit call for reducing emulated discardable memory usage.
6 years, 4 months ago (2014-08-12 03:53:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/458343003/1
6 years, 4 months ago (2014-08-12 03:54:52 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 03:56:45 UTC) #3
Message was sent while issue was closed.
Change committed as 288913

Powered by Google App Engine
This is Rietveld 408576698