extensions/browser/extension_function.h - Issue 458323002: Change GuestViewInternalCreateGuestFunction to create the guest view using the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/extension_function.h

Issue 458323002: Change GuestViewInternalCreateGuestFunction to create the guest view using the (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add test Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/platform_apps/web_view/background/background.html ('K') | « chrome/test/data/extensions/platform_apps/web_view/background/manifest.json ('k') | extensions/browser/extension_function.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/extension_function.h

diff --git a/extensions/browser/extension_function.h b/extensions/browser/extension_function.h

index 4cb41ad5d30e89eeda6bfce76d168d16e0f10a2c..5815f8e597f56219ab94c2862666a3cf6619d969 100644

--- a/extensions/browser/extension_function.h

+++ b/extensions/browser/extension_function.h

@@ -443,6 +443,11 @@ class UIThreadExtensionFunction : public ExtensionFunction {

// contents then defaults to the foremost one.

virtual content::WebContents* GetAssociatedWebContents();

+ // Gets the visible web contents if any. In many cases this will be the same

+ // WebContents as |GetAssociatedWebContents|, however not always, in

+ // particular when the function caller is a background page.

+ virtual content::WebContents* GetVisibleWebContents();

protected:

// Emits a message to the extension's devtools console.

void WriteToConsole(content::ConsoleMessageLevel level,