Browser side OZONE_NATIVE_BUFFER allocation

content/common/gpu/client/gpu_memory_buffer_impl.h

Index: content/common/gpu/client/gpu_memory_buffer_impl.h
diff --git a/content/common/gpu/client/gpu_memory_buffer_impl.h b/content/common/gpu/client/gpu_memory_buffer_impl.h
index 2565c02653a71a4ac1a0b46a991dd4154839d95b..0b2ea5e5edc83d6aa8d1870cde98b86cf519782b 100644
--- a/content/common/gpu/client/gpu_memory_buffer_impl.h
+++ b/content/common/gpu/client/gpu_memory_buffer_impl.h
@@ -11,6 +11,7 @@
 #include "ui/gfx/size.h"
 
 namespace content {
+class GpuMemoryBufferFactoryHost;
 
 // Provides common implementation of a GPU memory buffer.
 class GpuMemoryBufferImpl : public gfx::GpuMemoryBuffer {
@@ -29,11 +30,16 @@ class GpuMemoryBufferImpl : public gfx::GpuMemoryBuffer {
   // Allocates a GPU memory buffer with |size| and |internalformat| for |usage|
   // by |child_process|. The |handle| returned can be used by the
   // |child_process| to create an instance of this class.
-  static void AllocateForChildProcess(const gfx::Size& size,
-                                      unsigned internalformat,
-                                      unsigned usage,
-                                      base::ProcessHandle child_process,
-                                      const AllocationCallback& callback);
+  // The buffer is being allocated for |client_id| and |gpu_factory_host| can
+  // be used to talk to the GPU process.

[reveman, 2014/08/11 19:43:05]

I'm not sure we should mention GPU process here. From this interface's pov I
prefer to simply think of it as out-of-process allocation of buffers.

[achaulk, 2014/08/12 19:03:56]

Acknowledged.

+  static void AllocateForChildProcess(
+      const gfx::Size& size,
+      unsigned internalformat,
+      unsigned usage,
+      base::ProcessHandle child_process,
+      int client_id,

[reveman, 2014/08/11 19:43:05]

does child_id make more sense here? this is the first mention of "client" here
otherwise..

[achaulk, 2014/08/12 19:03:56]

Probably yeah

+      GpuMemoryBufferFactoryHost* gpu_factory_host,

[reveman, 2014/08/11 19:43:05]

The implementation of this interface should not be aware of the existence of a
GPU process. Just |factory| or |factory_host| would be better imo. 

[achaulk, 2014/08/12 19:03:56]

Done.

+      const AllocationCallback& callback);
 
   // Notify that GPU memory buffer has been deleted by |child_process|.
   static void DeletedByChildProcess(gfx::GpuMemoryBufferType type,