Browser side OZONE_NATIVE_BUFFER allocation

content/common/gpu/client/gpu_memory_buffer_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_COMMON_GPU_CLIENT_GPU_MEMORY_BUFFER_IMPL_H_
 #define CONTENT_COMMON_GPU_CLIENT_GPU_MEMORY_BUFFER_IMPL_H_
 
 #include "base/callback.h"
 #include "base/memory/scoped_ptr.h"
 #include "ui/gfx/gpu_memory_buffer.h"
 #include "ui/gfx/size.h"
 
 namespace content {
+class GpuMemoryBufferFactoryHost;
 
 // Provides common implementation of a GPU memory buffer.
 class GpuMemoryBufferImpl : public gfx::GpuMemoryBuffer {
  public:
   typedef base::Callback<void(const gfx::GpuMemoryBufferHandle& handle)>
       AllocationCallback;
 
   virtual ~GpuMemoryBufferImpl();
 
   // Creates a GPU memory buffer instance with |size| and |internalformat| for
   // |usage|.
   static scoped_ptr<GpuMemoryBufferImpl> Create(const gfx::Size& size,
                                                 unsigned internalformat,
                                                 unsigned usage);
 
   // Allocates a GPU memory buffer with |size| and |internalformat| for |usage|
   // by |child_process|. The |handle| returned can be used by the
   // |child_process| to create an instance of this class.
-  static void AllocateForChildProcess(const gfx::Size& size,
-                                      unsigned internalformat,
-                                      unsigned usage,
-                                      base::ProcessHandle child_process,
-                                      const AllocationCallback& callback);
+  // The buffer is being allocated for |client_id| and |gpu_factory_host| can
+  // be used to talk to the GPU process.

[reveman, 2014/08/11 19:43:05]

I'm not sure we should mention GPU process here. From this interface's pov I
prefer to simply think of it as out-of-process allocation of buffers.

[achaulk, 2014/08/12 19:03:56]

Acknowledged.

+  static void AllocateForChildProcess(
+      const gfx::Size& size,
+      unsigned internalformat,
+      unsigned usage,
+      base::ProcessHandle child_process,
+      int client_id,

[reveman, 2014/08/11 19:43:05]

does child_id make more sense here? this is the first mention of "client" here
otherwise..

[achaulk, 2014/08/12 19:03:56]

Probably yeah

+      GpuMemoryBufferFactoryHost* gpu_factory_host,

[reveman, 2014/08/11 19:43:05]

The implementation of this interface should not be aware of the existence of a
GPU process. Just |factory| or |factory_host| would be better imo. 

[achaulk, 2014/08/12 19:03:56]

Done.

+      const AllocationCallback& callback);
 
   // Notify that GPU memory buffer has been deleted by |child_process|.
   static void DeletedByChildProcess(gfx::GpuMemoryBufferType type,
                                     const gfx::GpuMemoryBufferId& id,
                                     base::ProcessHandle child_process);
 
   // Creates an instance from the given |handle|. |size| and |internalformat|
   // should match what was used to allocate the |handle|.
   static scoped_ptr<GpuMemoryBufferImpl> CreateFromHandle(
       const gfx::GpuMemoryBufferHandle& handle,
@@ skipping 19 matching lines @@
   const gfx::Size size_;
   const unsigned internalformat_;
   bool mapped_;
 
   DISALLOW_COPY_AND_ASSIGN(GpuMemoryBufferImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_COMMON_GPU_CLIENT_GPU_MEMORY_BUFFER_IMPL_H_