[DevTools] Removed ScriptState from createScriptCallStackForConsole

Source/bindings/core/v8/ScriptCallStackFactory.cpp

 /*
  * Copyright (c) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 93 matching lines @@
 PassRefPtrWillBeRawPtr<ScriptCallStack> createScriptCallStack(size_t maxStackSize, bool emptyStackIsAllowed)
 {
     v8::Isolate* isolate = v8::Isolate::GetCurrent();
     if (!isolate->InContext())
         return nullptr;
     v8::HandleScope handleScope(isolate);
     v8::Handle<v8::StackTrace> stackTrace(v8::StackTrace::CurrentStackTrace(isolate, maxStackSize, stackTraceOptions));
     return createScriptCallStack(stackTrace, maxStackSize, emptyStackIsAllowed, isolate);
 }
 
-PassRefPtrWillBeRawPtr<ScriptCallStack> createScriptCallStackForConsole(ScriptState* scriptState, size_t maxStackSize)
+PassRefPtrWillBeRawPtr<ScriptCallStack> createScriptCallStackForConsole(size_t maxStackSize)
 {
     size_t stackSize = 1;
     if (InspectorInstrumentation::hasFrontends()) {
-        if (InspectorInstrumentation::consoleAgentEnabled(scriptState->executionContext()))
+        v8::Isolate* isolate = v8::Isolate::GetCurrent();
+        if (InspectorInstrumentation::consoleAgentEnabled(currentExecutionContext(isolate)))

[vsevik, 2014/08/11 15:52:03]

These lines might be needed here, please check with yurys@
if (!isolate->InContext())
    return nullptr;
v8::HandleScope scope(isolate);

[kozyatinskiy1, 2014/08/11 16:05:34]

First check added. @yurus, could you please answer: do we really need a scope in
this case?

[aandrey, 2014/08/11 17:38:03]

1) Calling currentExecutionContext() when not in context should be fine since
https://codereview.chromium.org/16943006

2) You don't use v8::Handle<>'s, so handle scope not needed.

[kozyatinskiy1, 2014/08/11 17:50:42]

Thank you. Furthermore, this test may be useful here for a quick exit from the
function.

             stackSize = maxStackSize;
     }
     return createScriptCallStack(stackSize);
 }
 
 PassRefPtrWillBeRawPtr<ScriptArguments> createScriptArguments(ScriptState* scriptState, const v8::FunctionCallbackInfo<v8::Value>& v8arguments, unsigned skipArgumentCount)
 {
     Vector<ScriptValue> arguments;
     for (int i = skipArgumentCount; i < v8arguments.Length(); ++i)
         arguments.append(ScriptValue(scriptState, v8arguments[i]));
 
     return ScriptArguments::create(scriptState, arguments);
 }
 
 } // namespace blink