Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 16943006: V8 API: Add a missing NULL check into Isolate::GetCurrentContext(). (Closed)

Created:
7 years, 6 months ago by aandrey
Modified:
7 years, 6 months ago
Base URL:
https://chromium.googlesource.com/external/v8.git@master
Visibility:
Public.

Description

V8 API: Add a missing NULL check into Isolate::GetCurrentContext(). There is a missing NULL check for: "internal_isolate->context() != NULL". Right now before calling this method one should call v8::Context::InContext() first to perform this check, otherwise we may crash. But this static method will do this check on the current isolate, which may not be the same as a given one. BUG=249655 R=yurys@chromium.org,mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15266

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M src/api.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
aandrey
7 years, 6 months ago (2013-06-21 12:28:30 UTC) #1
aandrey
On 2013/06/21 12:28:30, aandrey wrote: Already lgtm'ed in https://codereview.appspot.com/10337043/
7 years, 6 months ago (2013-06-21 12:29:01 UTC) #2
yurys
Committed patchset #1 manually as r15266.
7 years, 6 months ago (2013-06-21 12:34:56 UTC) #3
Michael Starzinger
LGTM. Original CL: https://codereview.appspot.com/10337043/
7 years, 6 months ago (2013-06-21 12:37:53 UTC) #4
Jakob Kummerow
Should this be included in the V8 branch for Chrome M29?
7 years, 6 months ago (2013-06-21 13:07:55 UTC) #5
yurys
7 years, 6 months ago (2013-06-21 15:03:33 UTC) #6
Message was sent while issue was closed.
On 2013/06/21 13:07:55, Jakob wrote:
> Should this be included in the V8 branch for Chrome M29?

We discovered this issue on WebGL profiler only and came up with a workaround
for now so I don't think we should backport this change.

Powered by Google App Engine
This is Rietveld 408576698