Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1122)

Unified Diff: chromeos/ime/extension_ime_util_unittest.cc

Issue 457943002: Improve perforance for component IME extensions initialization by using map instead of vector in Co… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed tests. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/ime/extension_ime_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/ime/extension_ime_util_unittest.cc
diff --git a/chromeos/ime/extension_ime_util_unittest.cc b/chromeos/ime/extension_ime_util_unittest.cc
index e499e8b73c2223c8033e72e8b2585a394947e277..bc86f17baeb6fea9c9431ab4e1ed945602aea96b 100644
--- a/chromeos/ime/extension_ime_util_unittest.cc
+++ b/chromeos/ime/extension_ime_util_unittest.cc
@@ -37,18 +37,22 @@ TEST(ExtensionIMEUtilTest, GetExtensionIDFromInputMethodIDTest) {
TEST(ExtensionIMEUtilTest, IsExtensionIMETest) {
EXPECT_TRUE(extension_ime_util::IsExtensionIME(
- extension_ime_util::GetInputMethodID("abcde", "12345")));
+ extension_ime_util::GetInputMethodID(
+ "abcde_xxxxxxxxxxxxxxxxxxxxxxxxxx", "12345")));
EXPECT_FALSE(extension_ime_util::IsExtensionIME(
- extension_ime_util::GetComponentInputMethodID("abcde", "12345")));
+ extension_ime_util::GetComponentInputMethodID(
+ "abcde_xxxxxxxxxxxxxxxxxxxxxxxxxx", "12345")));
EXPECT_FALSE(extension_ime_util::IsExtensionIME(""));
EXPECT_FALSE(extension_ime_util::IsExtensionIME("mozc"));
}
TEST(ExtensionIMEUtilTest, IsComponentExtensionIMETest) {
EXPECT_TRUE(extension_ime_util::IsComponentExtensionIME(
- extension_ime_util::GetComponentInputMethodID("abcde", "12345")));
+ extension_ime_util::GetComponentInputMethodID(
+ "abcde_xxxxxxxxxxxxxxxxxxxxxxxxxx", "12345")));
EXPECT_FALSE(extension_ime_util::IsComponentExtensionIME(
- extension_ime_util::GetInputMethodID("abcde", "12345")));
+ extension_ime_util::GetInputMethodID(
+ "abcde_xxxxxxxxxxxxxxxxxxxxxxxxxx", "12345")));
EXPECT_FALSE(extension_ime_util::IsComponentExtensionIME(""));
EXPECT_FALSE(extension_ime_util::IsComponentExtensionIME("mozc"));
}
« no previous file with comments | « chromeos/ime/extension_ime_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698