Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: chromeos/ime/extension_ime_util_unittest.cc

Issue 457943002: Improve perforance for component IME extensions initialization by using map instead of vector in Co… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed tests. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chromeos/ime/extension_ime_util.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/ime/extension_ime_util.h" 5 #include "chromeos/ime/extension_ime_util.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
(...skipping 19 matching lines...) Expand all
30 "mozc"))); 30 "mozc")));
31 EXPECT_EQ("12345678901234567890123456789012", 31 EXPECT_EQ("12345678901234567890123456789012",
32 extension_ime_util::GetExtensionIDFromInputMethodID( 32 extension_ime_util::GetExtensionIDFromInputMethodID(
33 extension_ime_util::GetComponentInputMethodID( 33 extension_ime_util::GetComponentInputMethodID(
34 "12345678901234567890123456789012", 34 "12345678901234567890123456789012",
35 "mozc"))); 35 "mozc")));
36 } 36 }
37 37
38 TEST(ExtensionIMEUtilTest, IsExtensionIMETest) { 38 TEST(ExtensionIMEUtilTest, IsExtensionIMETest) {
39 EXPECT_TRUE(extension_ime_util::IsExtensionIME( 39 EXPECT_TRUE(extension_ime_util::IsExtensionIME(
40 extension_ime_util::GetInputMethodID("abcde", "12345"))); 40 extension_ime_util::GetInputMethodID(
41 "abcde_xxxxxxxxxxxxxxxxxxxxxxxxxx", "12345")));
41 EXPECT_FALSE(extension_ime_util::IsExtensionIME( 42 EXPECT_FALSE(extension_ime_util::IsExtensionIME(
42 extension_ime_util::GetComponentInputMethodID("abcde", "12345"))); 43 extension_ime_util::GetComponentInputMethodID(
44 "abcde_xxxxxxxxxxxxxxxxxxxxxxxxxx", "12345")));
43 EXPECT_FALSE(extension_ime_util::IsExtensionIME("")); 45 EXPECT_FALSE(extension_ime_util::IsExtensionIME(""));
44 EXPECT_FALSE(extension_ime_util::IsExtensionIME("mozc")); 46 EXPECT_FALSE(extension_ime_util::IsExtensionIME("mozc"));
45 } 47 }
46 48
47 TEST(ExtensionIMEUtilTest, IsComponentExtensionIMETest) { 49 TEST(ExtensionIMEUtilTest, IsComponentExtensionIMETest) {
48 EXPECT_TRUE(extension_ime_util::IsComponentExtensionIME( 50 EXPECT_TRUE(extension_ime_util::IsComponentExtensionIME(
49 extension_ime_util::GetComponentInputMethodID("abcde", "12345"))); 51 extension_ime_util::GetComponentInputMethodID(
52 "abcde_xxxxxxxxxxxxxxxxxxxxxxxxxx", "12345")));
50 EXPECT_FALSE(extension_ime_util::IsComponentExtensionIME( 53 EXPECT_FALSE(extension_ime_util::IsComponentExtensionIME(
51 extension_ime_util::GetInputMethodID("abcde", "12345"))); 54 extension_ime_util::GetInputMethodID(
55 "abcde_xxxxxxxxxxxxxxxxxxxxxxxxxx", "12345")));
52 EXPECT_FALSE(extension_ime_util::IsComponentExtensionIME("")); 56 EXPECT_FALSE(extension_ime_util::IsComponentExtensionIME(""));
53 EXPECT_FALSE(extension_ime_util::IsComponentExtensionIME("mozc")); 57 EXPECT_FALSE(extension_ime_util::IsComponentExtensionIME("mozc"));
54 } 58 }
55 59
56 TEST(ExtensionIMEUtilTest, IsMemberOfExtension) { 60 TEST(ExtensionIMEUtilTest, IsMemberOfExtension) {
57 const char* extention1 = "abcdefg"; 61 const char* extention1 = "abcdefg";
58 const char* extention2 = "hijklmn"; 62 const char* extention2 = "hijklmn";
59 const char* extention3 = "opqrstu"; 63 const char* extention3 = "opqrstu";
60 const char* engine_id1 = "12345"; 64 const char* engine_id1 = "12345";
61 const char* engine_id2 = "67890"; 65 const char* engine_id2 = "67890";
(...skipping 12 matching lines...) Expand all
74 extention1)); 78 extention1));
75 EXPECT_FALSE(extension_ime_util::IsMemberOfExtension(extention_1_engine_1, 79 EXPECT_FALSE(extension_ime_util::IsMemberOfExtension(extention_1_engine_1,
76 extention2)); 80 extention2));
77 EXPECT_FALSE(extension_ime_util::IsMemberOfExtension(extention_1_engine_2, 81 EXPECT_FALSE(extension_ime_util::IsMemberOfExtension(extention_1_engine_2,
78 extention2)); 82 extention2));
79 EXPECT_FALSE(extension_ime_util::IsMemberOfExtension(component_3_engine_3, 83 EXPECT_FALSE(extension_ime_util::IsMemberOfExtension(component_3_engine_3,
80 extention3)); 84 extention3));
81 } 85 }
82 86
83 } // namespace chromeos 87 } // namespace chromeos
OLDNEW
« no previous file with comments | « chromeos/ime/extension_ime_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698