Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: chromeos/ime/extension_ime_util.cc

Issue 457943002: Improve perforance for component IME extensions initialization by using map instead of vector in Co… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed tests. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/ime/extension_ime_util.cc
diff --git a/chromeos/ime/extension_ime_util.cc b/chromeos/ime/extension_ime_util.cc
index 322635f5e478cbe3f047981a8841f6b7831b7f02..ee37cae714aad5eef219585026d3c3bc34669582 100644
--- a/chromeos/ime/extension_ime_util.cc
+++ b/chromeos/ime/extension_ime_util.cc
@@ -39,15 +39,11 @@ std::string GetComponentInputMethodID(const std::string& extension_id,
std::string GetExtensionIDFromInputMethodID(
const std::string& input_method_id) {
- if (IsExtensionIME(input_method_id) &&
- input_method_id.size() >= kExtensionIMEPrefixLength +
- kExtensionIdLength) {
+ if (IsExtensionIME(input_method_id)) {
return input_method_id.substr(kExtensionIMEPrefixLength,
kExtensionIdLength);
}
- if (IsComponentExtensionIME(input_method_id) &&
- input_method_id.size() >= kComponentExtensionIMEPrefixLength +
- kExtensionIdLength) {
+ if (IsComponentExtensionIME(input_method_id)) {
return input_method_id.substr(kComponentExtensionIMEPrefixLength,
kExtensionIdLength);
}
@@ -99,20 +95,24 @@ std::string GetInputMethodIDByEngineID(const std::string& engine_id) {
bool IsExtensionIME(const std::string& input_method_id) {
return StartsWithASCII(input_method_id,
kExtensionIMEPrefix,
- true); // Case sensitive.
+ true /* Case sensitive */) &&
+ input_method_id.size() > kExtensionIMEPrefixLength +
+ kExtensionIdLength;
}
bool IsComponentExtensionIME(const std::string& input_method_id) {
return StartsWithASCII(input_method_id,
kComponentExtensionIMEPrefix,
- true); // Case sensitive.
+ true /* Case sensitive */) &&
+ input_method_id.size() > kComponentExtensionIMEPrefixLength +
+ kExtensionIdLength;
}
bool IsMemberOfExtension(const std::string& input_method_id,
const std::string& extension_id) {
return StartsWithASCII(input_method_id,
kExtensionIMEPrefix + extension_id,
- true); // Case sensitive.
+ true /* Case sensitive */);
}
bool IsKeyboardLayoutExtension(const std::string& input_method_id) {
« no previous file with comments | « chromeos/ime/component_extension_ime_manager_unittest.cc ('k') | chromeos/ime/extension_ime_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698