Improve perforance for component IME extensions initialization by using map instead of vector in Co…

chromeos/ime/extension_ime_util.cc

Index: chromeos/ime/extension_ime_util.cc
diff --git a/chromeos/ime/extension_ime_util.cc b/chromeos/ime/extension_ime_util.cc
index 322635f5e478cbe3f047981a8841f6b7831b7f02..898dd4601e6a6b7956fed0e0c8d6ba17528c272d 100644
--- a/chromeos/ime/extension_ime_util.cc
+++ b/chromeos/ime/extension_ime_util.cc
@@ -55,10 +55,14 @@ std::string GetExtensionIDFromInputMethodID(
 }
 
 std::string GetComponentIDByInputMethodID(const std::string& input_method_id) {
-  if (IsComponentExtensionIME(input_method_id))
+  if (IsComponentExtensionIME(input_method_id) &&
+      input_method_id.size() >= kComponentExtensionIMEPrefixLength +

[Seigo Nonaka, 2014/08/11 16:41:06]

Is this check necessary?
If so, how about moving this check into IsComponentExtensionIME?

[Shu Chen, 2014/08/12 04:44:06]

Done.

+                                kExtensionIdLength)
     return input_method_id.substr(kComponentExtensionIMEPrefixLength +
                                   kExtensionIdLength);
-  if (IsExtensionIME(input_method_id))
+  if (IsExtensionIME(input_method_id) &&
+      input_method_id.size() >= kExtensionIMEPrefixLength +

[Seigo Nonaka, 2014/08/11 16:41:06]

same as above.

[Shu Chen, 2014/08/12 04:44:07]

Done.

+                                kExtensionIdLength)
     return input_method_id.substr(kExtensionIMEPrefixLength +
                                   kExtensionIdLength);
   return input_method_id;