Improve perforance for component IME extensions initialization by using map instead of vector in Co…

chromeos/ime/extension_ime_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/ime/extension_ime_util.h"
 
 #include "base/strings/string_util.h"
 
 namespace chromeos {
 
@@ skipping 37 matching lines @@
   if (IsComponentExtensionIME(input_method_id) &&
       input_method_id.size() >= kComponentExtensionIMEPrefixLength +
                                 kExtensionIdLength) {
     return input_method_id.substr(kComponentExtensionIMEPrefixLength,
                                   kExtensionIdLength);
   }
   return "";
 }
 
 std::string GetComponentIDByInputMethodID(const std::string& input_method_id) {
-  if (IsComponentExtensionIME(input_method_id))
+  if (IsComponentExtensionIME(input_method_id) &&
+      input_method_id.size() >= kComponentExtensionIMEPrefixLength +

[Seigo Nonaka, 2014/08/11 16:41:06]

Is this check necessary?
If so, how about moving this check into IsComponentExtensionIME?

[Shu Chen, 2014/08/12 04:44:06]

Done.

+                                kExtensionIdLength)
     return input_method_id.substr(kComponentExtensionIMEPrefixLength +
                                   kExtensionIdLength);
-  if (IsExtensionIME(input_method_id))
+  if (IsExtensionIME(input_method_id) &&
+      input_method_id.size() >= kExtensionIMEPrefixLength +

[Seigo Nonaka, 2014/08/11 16:41:06]

same as above.

[Shu Chen, 2014/08/12 04:44:07]

Done.

+                                kExtensionIdLength)
     return input_method_id.substr(kExtensionIMEPrefixLength +
                                   kExtensionIdLength);
   return input_method_id;
 }
 
 std::string GetInputMethodIDByEngineID(const std::string& engine_id) {
   if (StartsWithASCII(engine_id, kComponentExtensionIMEPrefix, true) ||
       StartsWithASCII(engine_id, kExtensionIMEPrefix, true)) {
     return engine_id;
   }
@@ skipping 49 matching lines @@
 }
 
 std::string MaybeGetLegacyXkbId(const std::string& input_method_id) {
   if (IsKeyboardLayoutExtension(input_method_id))
     return GetComponentIDByInputMethodID(input_method_id);
   return input_method_id;
 }
 
 }  // namespace extension_ime_util
 }  // namespace chromeos