Android WebView: flush input events during onVSync

content/browser/renderer_host/render_widget_host_view_android.cc

Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index 19b64c6f5043fcfa27550f8a4529401dd24284a6..e2034513f6f6f80be14ffe45130f029547a65551 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -258,7 +258,7 @@ void RenderWidgetHostViewAndroid::WasShown() {
 
   host_->WasShown();
 
-  if (content_view_core_ && !using_synchronous_compositor_) {
+  if (content_view_core_) {

[hush (inactive), 2014/08/09 03:28:12]

btw, WasShown() is not called when you use Aw TestShell, nor ContentShellShell.
Not sure when it is supposed to be called.

[boliu, 2014/08/11 15:57:47]

Should be called in aw shell from here:
https://code.google.com/p/chromium/codesearch#chromium/src/android_webview/ja...

Also this change is not ok. Now it's going to request vsyncs and start sending
ipc like ViewMsg_BeginFrame. I don't even know what would happen in that case.

     content_view_core_->GetWindowAndroid()->AddObserver(this);
     content_view_core_->GetWindowAndroid()->RequestVSyncUpdate();
     observing_root_window_ = true;
@@ -275,7 +275,7 @@ void RenderWidgetHostViewAndroid::WasHidden() {
   // utilization.
   host_->WasHidden();
 
-  if (content_view_core_ && !using_synchronous_compositor_) {
+  if (content_view_core_) {
     content_view_core_->GetWindowAndroid()->RemoveObserver(this);
     observing_root_window_ = false;
   }
@@ -1440,12 +1440,10 @@ void RenderWidgetHostViewAndroid::SetContentViewCore(
   if (!content_view_core_)
     return;
 
-  if (!using_synchronous_compositor_) {
-    content_view_core_->GetWindowAndroid()->AddObserver(this);
-    observing_root_window_ = true;
-    if (needs_begin_frame_)
-      content_view_core_->GetWindowAndroid()->RequestVSyncUpdate();
-  }
+  content_view_core_->GetWindowAndroid()->AddObserver(this);
+  observing_root_window_ = true;
+  if (needs_begin_frame_)
+    content_view_core_->GetWindowAndroid()->RequestVSyncUpdate();
 
   if (resize)
     WasResized();