Android WebView: flush input events during onVSync

content/browser/renderer_host/render_widget_host_view_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_android.h"
 
 #include <android/bitmap.h>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
@@ skipping 240 matching lines @@
 RenderWidgetHostViewAndroid::GetRenderWidgetHost() const {
   return host_;
 }
 
 void RenderWidgetHostViewAndroid::WasShown() {
   if (!host_ || !host_->is_hidden())
     return;
 
   host_->WasShown();
 
-  if (content_view_core_ && !using_synchronous_compositor_) {
+  if (content_view_core_) {

[hush (inactive), 2014/08/09 03:28:12]

btw, WasShown() is not called when you use Aw TestShell, nor ContentShellShell.
Not sure when it is supposed to be called.

[boliu, 2014/08/11 15:57:47]

Should be called in aw shell from here:
https://code.google.com/p/chromium/codesearch#chromium/src/android_webview/ja...

Also this change is not ok. Now it's going to request vsyncs and start sending
ipc like ViewMsg_BeginFrame. I don't even know what would happen in that case.

     content_view_core_->GetWindowAndroid()->AddObserver(this);
     content_view_core_->GetWindowAndroid()->RequestVSyncUpdate();
     observing_root_window_ = true;
   }
 }
 
 void RenderWidgetHostViewAndroid::WasHidden() {
   RunAckCallbacks();
 
   if (!host_ || host_->is_hidden())
     return;
 
   // Inform the renderer that we are being hidden so it can reduce its resource
   // utilization.
   host_->WasHidden();
 
-  if (content_view_core_ && !using_synchronous_compositor_) {
+  if (content_view_core_) {
     content_view_core_->GetWindowAndroid()->RemoveObserver(this);
     observing_root_window_ = false;
   }
 }
 
 void RenderWidgetHostViewAndroid::WasResized() {
   host_->WasResized();
 }
 
 void RenderWidgetHostViewAndroid::SetSize(const gfx::Size& size) {
@@ skipping 1144 matching lines @@
     if (content_view_core_)
       obj = content_view_core_->GetJavaObject();
     manager->ToBrowserAccessibilityManagerAndroid()->SetContentViewCore(obj);
   }
 
   AttachLayers();
 
   if (!content_view_core_)
     return;
 
-  if (!using_synchronous_compositor_) {
-    content_view_core_->GetWindowAndroid()->AddObserver(this);
-    observing_root_window_ = true;
-    if (needs_begin_frame_)
-      content_view_core_->GetWindowAndroid()->RequestVSyncUpdate();
-  }
+  content_view_core_->GetWindowAndroid()->AddObserver(this);
+  observing_root_window_ = true;
+  if (needs_begin_frame_)
+    content_view_core_->GetWindowAndroid()->RequestVSyncUpdate();
 
   if (resize)
     WasResized();
 
   if (!selection_controller_)
     selection_controller_.reset(new TouchSelectionController(this));
 }
 
 void RenderWidgetHostViewAndroid::RunAckCallbacks() {
   while (!ack_callbacks_.empty()) {
@@ skipping 191 matching lines @@
   results->orientationAngle = display.RotationAsDegree();
   results->orientationType =
       RenderWidgetHostViewBase::GetOrientationTypeForMobile(display);
   gfx::DeviceDisplayInfo info;
   results->depth = info.GetBitsPerPixel();
   results->depthPerComponent = info.GetBitsPerComponent();
   results->isMonochrome = (results->depthPerComponent == 0);
 }
 
 } // namespace content