Issue 457753002: add dummy onDrawPicture to allow migration for chrome overrides

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 457753002: add dummy onDrawPicture to allow migration for chrome overrides (Closed)

Created:
6 years, 4 months ago by reed1

Modified:
6 years, 4 months ago

Reviewers:
f(malita), fmalita_google_do_not_use, robertphillips

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

add dummy onDrawPicture to allow migration for chrome overrides after this lands in chrome, land these two CLs https://codereview.chromium.org/454993002/ https://codereview.chromium.org/454143003 then land this skia CL https://codereview.chromium.org/448793004/ then remove the onDrawPicture overrides from chrome Committed: https://skia.googlesource.com/skia/+/3b1c3d2c6160f714c4ebada05dd834f88fe5fd00

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	include/core/SkCanvas.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/457753002/1

6 years, 4 months ago (2014-08-08 19:29:37 UTC) #3

commit-bot: I haz the power

Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...

6 years, 4 months ago (2014-08-08 19:29:38 UTC) #4

commit-bot: I haz the power

6 years, 4 months ago (2014-08-08 19:51:31 UTC) #6

Message was sent while issue was closed.

Change committed as 3b1c3d2c6160f714c4ebada05dd834f88fe5fd00