Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 454143003: preemptively add new override for onDrawPicture (Closed)

Created:
6 years, 4 months ago by reed1
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

preemptively add new override for onDrawPicture skia is changing the signature for onDrawPicture, so this CL adds the new one, and removes OVERRIDE from the old. BUG=

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M skia/ext/benchmarking_canvas.cc View 1 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
reed1
6 years, 4 months ago (2014-08-08 19:29:33 UTC) #1
f(malita)
lgtm
6 years, 4 months ago (2014-08-08 19:47:44 UTC) #2
reed2
The CQ bit was checked by reed@chromium.org
6 years, 4 months ago (2014-08-09 15:33:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/454143003/1
6 years, 4 months ago (2014-08-09 15:34:08 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-09 15:55:34 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-09 15:57:04 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-09 15:57:05 UTC) #7
Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

Powered by Google App Engine
This is Rietveld 408576698