Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1347)

Unified Diff: Source/platform/credentialmanager/PlatformCredential.h

Issue 457683002: Credential Manager: Add platform-exposed Credential objects. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Strings. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/credentialmanager/PlatformCredential.h
diff --git a/Source/modules/credentialmanager/Credential.h b/Source/platform/credentialmanager/PlatformCredential.h
similarity index 50%
copy from Source/modules/credentialmanager/Credential.h
copy to Source/platform/credentialmanager/PlatformCredential.h
index 38889e5797a72b9a3ab73c473ef1541c49f4c166..41dddb58c1399d9cf9d15abeeb08ed1250d38e7a 100644
--- a/Source/modules/credentialmanager/Credential.h
+++ b/Source/platform/credentialmanager/PlatformCredential.h
@@ -2,21 +2,22 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef Credential_h
-#define Credential_h
+#ifndef PlatformCredential_h
+#define PlatformCredential_h
-#include "bindings/core/v8/ScriptWrappable.h"
-#include "bindings/core/v8/SerializedScriptValue.h"
#include "platform/heap/Handle.h"
+#include "wtf/text/WTFString.h"
namespace blink {
-class Credential : public GarbageCollectedFinalized<Credential>, public ScriptWrappable {
+class WebPlatformCredential;
+
+class PLATFORM_EXPORT PlatformCredential : public GarbageCollectedFinalized<PlatformCredential> {
+ WTF_MAKE_NONCOPYABLE(PlatformCredential);
public:
- static Credential* create(const String& id, const String& name, const String& avatarURL);
- virtual ~Credential();
+ static PlatformCredential* create(const String& id, const String& name, const String& avatarURL);
+ virtual ~PlatformCredential();
- // Credential.idl
const String& id() const { return m_id; }
const String& name() const { return m_name; }
const String& avatarURL() const { return m_avatarURL; }
@@ -24,7 +25,7 @@ public:
virtual void trace(Visitor*) { };
sof 2014/08/10 05:54:57 nit: stray semi.
Mike West 2014/08/11 07:56:49 Done.
protected:
- Credential(const String& id, const String& name, const String& avatarURL);
+ PlatformCredential(const String& id, const String& name, const String& avatarURL);
private:
String m_id;
@@ -34,4 +35,4 @@ private:
} // namespace blink
-#endif // Credential_h
+#endif // PlatformCredential_h

Powered by Google App Engine
This is Rietveld 408576698