Credential Manager: Add platform-exposed Credential objects.

Source/modules/credentialmanager/Credential.h

Index: Source/modules/credentialmanager/Credential.h
diff --git a/Source/modules/credentialmanager/Credential.h b/Source/modules/credentialmanager/Credential.h
index 38889e5797a72b9a3ab73c473ef1541c49f4c166..aaffcd9d83a7c7e4dbe86753d00591e2dfc39343 100644
--- a/Source/modules/credentialmanager/Credential.h
+++ b/Source/modules/credentialmanager/Credential.h
@@ -7,29 +7,30 @@
 
 #include "bindings/core/v8/ScriptWrappable.h"
 #include "bindings/core/v8/SerializedScriptValue.h"
+#include "platform/credentialmanager/PlatformCredential.h"
 #include "platform/heap/Handle.h"
 
 namespace blink {
 
+class WebCredential;
+
 class Credential : public GarbageCollectedFinalized<Credential>, public ScriptWrappable {

[sof, 2014/08/10 05:54:57]

This base class no longer needs to be finalized (which transitively holds for
its hierarchy), so this can be just GarbageCollected<Credential> -- the
finalization of the Strings now happening via the platform Member objects
instead.

The dtor decl+defn also needs to be removed (here and for the derived classes.)

If you feel like the classes haven't stabilized and you may well end up adding
fields that do require finalization, this change is clearly not worth doing, at
least not now.

(The clang plugin/extension supporting Oilpan will catch and report classes that
grow fields that do require finalization, so this won't silently break.)

[Mike West, 2014/08/10 11:39:52]

In the future, I don't expect Credential to change much, but I do expect
subclasses to sprout nontrivial members (LocalCredential will almost certainly
grow a FormData at some point). What's the right way to model that from an
oilpan perspective?

[sof, 2014/08/10 13:14:15]

Assuming FormData isn't turned into a GCed object by then (as part of moving
Resource-related objects to the heap), the Credential base class will have to
become *Finalized again.

For now, add a "FIXME: Oilpan:" comment about considering the use of the
non-finalized GarbageCollected<> base class once this module has settled down a
bit?

 public:
     static Credential* create(const String& id, const String& name, const String& avatarURL);
     virtual ~Credential();
 
     // Credential.idl
-    const String& id() const { return m_id; }
-    const String& name() const { return m_name; }
-    const String& avatarURL() const { return m_avatarURL; }
+    const String& id() const { return m_private->id(); }
+    const String& name() const { return m_private->name(); }
+    const String& avatarURL() const { return m_private->avatarURL(); }
 
-    virtual void trace(Visitor*) { };
+    virtual void trace(Visitor*);
 
 protected:
+    Credential(PlatformCredential*);

[sof, 2014/08/10 05:54:57]

Perhaps you want an implicit conversion, but if not add 'explicit'?

[Mike West, 2014/08/11 07:56:49]

Done.

     Credential(const String& id, const String& name, const String& avatarURL);
 
-private:
-    String m_id;
-    String m_name;
-    String m_avatarURL;
+    Member<PlatformCredential> m_private;

[sof, 2014/08/10 05:54:57]

Possible to come up with a better name?

[Mike West, 2014/08/11 07:56:49]

Done.

 };
 
 } // namespace blink