Remove left-overs from -webkit-marquee-speed removal.

Remove left-overs from -webkit-marquee-speed removal.

The slow, normal, and fast keywords, and the seconds unit, are not used by
the presentational style for the marquee element.

R=jchaffraix@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179896

[Julien - ping for review, 2014-08-08 17:18:35]

lgtm

https://codereview.chromium.org/457633002/diff/20001/Source/core/css/CSSPrope...
File Source/core/css/CSSProperties.in (right):

https://codereview.chromium.org/457633002/diff/20001/Source/core/css/CSSPrope...
Source/core/css/CSSProperties.in:227: -internal-marquee-speed
name_for_methods=MarqueeSpeed, converter=convertNumberOrPercentage
I would have said that we should just use convertLength to match what we pass in
HTMLMarquee. However we are only interested in numbers as we filter them down in
validUnit below and we don't have a convertNumber function so I guess I could
live with either converter.

https://codereview.chromium.org/457633002/diff/20001/Source/core/css/parser/C...
File Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/457633002/diff/20001/Source/core/css/parser/C...
Source/core/css/parser/CSSPropertyParser.cpp:1127: validPrimitive =
validUnit(value, FTime | FInteger | FNonNeg);
I don't think we need FTime here as we pass in a Length.

[rune, 2014-08-10 17:13:36]

https://codereview.chromium.org/457633002/diff/20001/Source/core/css/CSSPrope...
File Source/core/css/CSSProperties.in (right):

https://codereview.chromium.org/457633002/diff/20001/Source/core/css/CSSPrope...
Source/core/css/CSSProperties.in:227: -internal-marquee-speed
name_for_methods=MarqueeSpeed, converter=convertNumberOrPercentage
On 2014/08/08 17:18:34, Julien Chaffraix - PST wrote:
> I would have said that we should just use convertLength to match what we pass
in
> HTMLMarquee. However we are only interested in numbers as we filter them down
in
> validUnit below and we don't have a convertNumber function so I guess I could
> live with either converter.

convertLength passes a Length into the RenderStyle setter which fails
compilation. I'll go with convertNumberOrPercentage.

https://codereview.chromium.org/457633002/diff/20001/Source/core/css/parser/C...
File Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/457633002/diff/20001/Source/core/css/parser/C...
Source/core/css/parser/CSSPropertyParser.cpp:1127: validPrimitive =
validUnit(value, FTime | FInteger | FNonNeg);
On 2014/08/08 17:18:34, Julien Chaffraix - PST wrote:
> I don't think we need FTime here as we pass in a Length.

Done.

[rune, 2014-08-10 17:13:57]

The CQ bit was checked by rune@opera.com

[commit-bot: I haz the power, 2014-08-10 17:14:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rune@opera.com/457633002/40001

[commit-bot: I haz the power, 2014-08-10 18:16:22]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/21925)

[commit-bot: I haz the power, 2014-08-10 18:45:47]

Change committed as 179896