Source/core/css/CSSProperties.in - Issue 457633002: Remove left-overs from -webkit-marquee-speed removal.

Side by Side Diff: Source/core/css/CSSProperties.in

Issue 457633002: Remove left-overs from -webkit-marquee-speed removal. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed inspector regression. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | Source/core/css/CSSValueKeywords.in » ('j') | Source/core/css/parser/CSSPropertyParser.cpp » ('J')

OLD	NEW
1 // FIXME: When we have all the properties using the new StyleBuilder, we	1 // FIXME: When we have all the properties using the new StyleBuilder, we

2 // should use this for make_css_property_names.py	2 // should use this for make_css_property_names.py

3 // Note that type_name is currently only used for non-custom value application	3 // Note that type_name is currently only used for non-custom value application

4 // and when explicitly referred to in generated applicators.	4 // and when explicitly referred to in generated applicators.

5 // Note: Mandatory blank line to skip parameter parsing phase	5 // Note: Mandatory blank line to skip parameter parsing phase

6	6

7 align-content	7 align-content

8 align-items custom_all	8 align-items custom_all

9 align-self custom_all	9 align-self custom_all

10 background-attachment custom_all	10 background-attachment custom_all

(...skipping 206 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
217 -webkit-line-break type_name=LineBreak	217 -webkit-line-break type_name=LineBreak

218 -webkit-line-clamp type_name=LineClampValue	218 -webkit-line-clamp type_name=LineClampValue

219 -webkit-locale custom_value	219 -webkit-locale custom_value

220 -webkit-margin-after-collapse type_name=EMarginCollapse	220 -webkit-margin-after-collapse type_name=EMarginCollapse

221 -webkit-margin-before-collapse type_name=EMarginCollapse	221 -webkit-margin-before-collapse type_name=EMarginCollapse

222 -webkit-margin-bottom-collapse type_name=EMarginCollapse, name_for_methods=Margi nAfterCollapse	222 -webkit-margin-bottom-collapse type_name=EMarginCollapse, name_for_methods=Margi nAfterCollapse

223 -webkit-margin-top-collapse type_name=EMarginCollapse, name_for_methods=MarginBe foreCollapse	223 -webkit-margin-top-collapse type_name=EMarginCollapse, name_for_methods=MarginBe foreCollapse

224 -internal-marquee-direction name_for_methods=MarqueeDirection	224 -internal-marquee-direction name_for_methods=MarqueeDirection

225 -internal-marquee-increment name_for_methods=MarqueeIncrement, converter=convert Length	225 -internal-marquee-increment name_for_methods=MarqueeIncrement, converter=convert Length

226 -internal-marquee-repetition type_name=int, name_for_methods=MarqueeLoopCount, c ustom_value	226 -internal-marquee-repetition type_name=int, name_for_methods=MarqueeLoopCount, c ustom_value

227 -internal-marquee-speed custom_value, name_for_methods=MarqueeSpeed	227 -internal-marquee-speed name_for_methods=MarqueeSpeed, converter=convertNumberOr Percentage
	Julien - ping for review 2014/08/08 17:18:34 I would have said that we should just use convertL I would have said that we should just use convertLength to match what we pass in HTMLMarquee. However we are only interested in numbers as we filter them down in validUnit below and we don't have a convertNumber function so I guess I could live with either converter. rune 2014/08/10 17:13:36 convertLength passes a Length into the RenderStyle Show quoted text On 2014/08/08 17:18:34, Julien Chaffraix - PST wrote: > I would have said that we should just use convertLength to match what we pass in > HTMLMarquee. However we are only interested in numbers as we filter them down in > validUnit below and we don't have a convertNumber function so I guess I could > live with either converter. convertLength passes a Length into the RenderStyle setter which fails compilation. I'll go with convertNumberOrPercentage.
228 -internal-marquee-style name_for_methods=MarqueeBehavior	228 -internal-marquee-style name_for_methods=MarqueeBehavior

229 -webkit-mask-box-image-outset custom_all	229 -webkit-mask-box-image-outset custom_all

230 -webkit-mask-box-image-repeat custom_all	230 -webkit-mask-box-image-repeat custom_all

231 -webkit-mask-box-image-slice custom_all	231 -webkit-mask-box-image-slice custom_all

232 -webkit-mask-box-image-source custom_value	232 -webkit-mask-box-image-source custom_value

233 -webkit-mask-box-image-width custom_all	233 -webkit-mask-box-image-width custom_all

234 -webkit-mask-clip custom_all	234 -webkit-mask-clip custom_all

235 -webkit-mask-composite custom_all	235 -webkit-mask-composite custom_all

236 -webkit-mask-image custom_all	236 -webkit-mask-image custom_all

237 -webkit-mask-origin custom_all	237 -webkit-mask-origin custom_all

(...skipping 123 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
361 unicode-range skip	361 unicode-range skip

362 -webkit-font-size-delta skip	362 -webkit-font-size-delta skip

363 -webkit-text-decorations-in-effect skip	363 -webkit-text-decorations-in-effect skip

364 max-zoom skip	364 max-zoom skip

365 min-zoom skip	365 min-zoom skip

366 user-zoom skip	366 user-zoom skip

367 orientation skip	367 orientation skip

368 enable-background skip	368 enable-background skip

369 invalid skip	369 invalid skip

370 all skip	370 all skip

OLD	NEW