Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 457353002: Cleanup namespace usage in public/platform/Web[A-M]*.h. (Closed)

Created:
6 years, 4 months ago by tkent
Modified:
6 years, 4 months ago
Reviewers:
keishi
CC:
blink-reviews, jamesr, tzik, eric.carlson_apple.com, philipj_slow, alecflett, dcheng, abarth-chromium, feature-media-reviews_chromium.org, dglazkov+blink, dgrogan, nhiroki, cmumford, jsbell+idb_chromium.org, kinuko+fileapi
Project:
blink
Visibility:
Public.

Description

Cleanup namespace usage in public/platform/{Platform,Web[A-M]*}.h. - Merge multiple |namespace blink {}| blocks - Remove unnecessary blink:: prefixes - Make blank lines consistent BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179942

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -166 lines) Patch
M public/platform/Platform.h View 2 chunks +3 lines, -3 lines 0 comments Download
M public/platform/WebAudioBus.h View 3 chunks +3 lines, -4 lines 0 comments Download
M public/platform/WebAudioSourceProviderClient.h View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebBlobData.h View 2 chunks +6 lines, -5 lines 0 comments Download
M public/platform/WebBlobRegistry.h View 1 chunk +5 lines, -5 lines 0 comments Download
M public/platform/WebCompositorSupport.h View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebContentDecryptionModuleResult.h View 2 chunks +3 lines, -6 lines 0 comments Download
M public/platform/WebContentLayer.h View 1 chunk +0 lines, -1 line 0 comments Download
M public/platform/WebContentLayerClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M public/platform/WebConvertableToTraceFormat.h View 2 chunks +3 lines, -5 lines 0 comments Download
M public/platform/WebCookieJar.h View 1 chunk +1 line, -0 lines 0 comments Download
M public/platform/WebCrypto.h View 2 chunks +3 lines, -4 lines 0 comments Download
M public/platform/WebCursorInfo.h View 3 chunks +3 lines, -5 lines 0 comments Download
M public/platform/WebData.h View 3 chunks +5 lines, -6 lines 0 comments Download
M public/platform/WebDragData.h View 2 chunks +5 lines, -6 lines 0 comments Download
M public/platform/WebFileSystemCallbacks.h View 2 chunks +3 lines, -5 lines 0 comments Download
M public/platform/WebFloatPoint.h View 1 chunk +4 lines, -4 lines 0 comments Download
M public/platform/WebFloatPoint3D.h View 2 chunks +4 lines, -4 lines 0 comments Download
M public/platform/WebFloatRect.h View 3 chunks +4 lines, -4 lines 0 comments Download
M public/platform/WebFloatSize.h View 1 chunk +4 lines, -4 lines 0 comments Download
M public/platform/WebGamepadListener.h View 1 chunk +2 lines, -2 lines 0 comments Download
M public/platform/WebGraphicsContext3DProvider.h View 1 chunk +1 line, -0 lines 0 comments Download
M public/platform/WebHTTPBody.h View 2 chunks +4 lines, -4 lines 0 comments Download
M public/platform/WebHTTPLoadInfo.h View 2 chunks +4 lines, -6 lines 0 comments Download
M public/platform/WebIDBDatabase.h View 2 chunks +3 lines, -3 lines 0 comments Download
M public/platform/WebIDBDatabaseError.h View 2 chunks +4 lines, -4 lines 0 comments Download
M public/platform/WebIDBKey.h View 2 chunks +6 lines, -6 lines 0 comments Download
M public/platform/WebIDBKeyPath.h View 2 chunks +6 lines, -6 lines 0 comments Download
M public/platform/WebIDBKeyRange.h View 2 chunks +5 lines, -6 lines 0 comments Download
M public/platform/WebIDBMetadata.h View 2 chunks +3 lines, -6 lines 0 comments Download
M public/platform/WebImage.h View 3 chunks +3 lines, -4 lines 0 comments Download
M public/platform/WebLayer.h View 1 chunk +1 line, -0 lines 0 comments Download
M public/platform/WebLayerTreeView.h View 1 chunk +1 line, -0 lines 0 comments Download
M public/platform/WebMediaStream.h View 2 chunks +7 lines, -10 lines 0 comments Download
M public/platform/WebMediaStreamCenter.h View 1 chunk +1 line, -0 lines 0 comments Download
M public/platform/WebMediaStreamCenterClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M public/platform/WebMediaStreamSource.h View 3 chunks +8 lines, -10 lines 0 comments Download
M public/platform/WebMediaStreamTrack.h View 3 chunks +9 lines, -11 lines 0 comments Download
M public/platform/WebMediaStreamTrackSourcesRequest.h View 2 chunks +3 lines, -5 lines 0 comments Download
M public/platform/WebMimeRegistry.h View 1 chunk +11 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tkent
Please review this.
6 years, 4 months ago (2014-08-11 10:58:59 UTC) #1
keishi
LGTM
6 years, 4 months ago (2014-08-11 11:03:15 UTC) #2
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 4 months ago (2014-08-11 11:04:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/457353002/1
6 years, 4 months ago (2014-08-11 11:05:08 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 12:01:31 UTC) #5
Message was sent while issue was closed. 
Change committed as 179942

Powered by Google App Engine
This is Rietveld 408576698