Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 45733012: Disable ActivityLogApiTest.TriggerEvent while waiting for Blink roll (Closed)

Created:
7 years, 1 month ago by davve
Modified:
7 years, 1 month ago
Reviewers:
benwells, felt, Matt Perry
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, felt, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Disable ActivityLogApiTest.TriggerEvent while waiting for Blink roll Blink will move innerHTML from HTMLElement from Element. Because this test relies on the exact placement of the function, disable it during the transition. BUG=311080 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231961

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add line break #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
davve
7 years, 1 month ago (2013-10-30 13:52:54 UTC) #1
felt
Do you plan to update & re-enable the test? lgtm with a nit. https://codereview.chromium.org/45733012/diff/1/chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc File ...
7 years, 1 month ago (2013-10-30 14:24:55 UTC) #2
davve
On 2013/10/30 14:24:55, felt wrote: > Do you plan to update & re-enable the test? ...
7 years, 1 month ago (2013-10-30 14:29:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/45733012/60001
7 years, 1 month ago (2013-10-30 14:31:19 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=215750
7 years, 1 month ago (2013-10-30 17:48:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/45733012/60001
7 years, 1 month ago (2013-10-30 19:07:53 UTC) #6
Matt Perry
lgtm
7 years, 1 month ago (2013-10-30 19:21:37 UTC) #7
felt
I just added NOTRY=true to the issue to get it through the CQ faster. Since ...
7 years, 1 month ago (2013-10-30 21:24:32 UTC) #8
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 1 month ago (2013-10-30 23:14:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/45733012/60001
7 years, 1 month ago (2013-10-30 23:58:48 UTC) #10
commit-bot: I haz the power
7 years, 1 month ago (2013-10-31 00:40:12 UTC) #11
Message was sent while issue was closed.
Change committed as 231961

Powered by Google App Engine
This is Rietveld 408576698