Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 52203002: Revert "Move innerHTML and outerHTML to Element" (Closed)

Created:
7 years, 1 month ago by yurys
Modified:
7 years, 1 month ago
Reviewers:
davve, tmroeder, mvrable
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, Inactive, karenlees
Visibility:
Public.

Description

Revert "Move innerHTML and outerHTML to Element" This reverts commit 160869 as it broke ActivityLogApiTest.TriggerEvent browser test: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&testType=browser_tests&tests=ActivityLogApiTest.TriggerEvent I'm not sure how severe the problem is so I'd rather revert the offending change than disable the test on Blink roll. BUG=311080 TBR=davve@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -295 lines) Patch
D LayoutTests/fast/innerHTML/innerHTML-svg-read.html View 1 chunk +0 lines, -36 lines 0 comments Download
D LayoutTests/fast/innerHTML/innerHTML-svg-read-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/innerHTML/innerHTML-svg-write.html View 1 chunk +0 lines, -34 lines 0 comments Download
D LayoutTests/fast/innerHTML/innerHTML-svg-write-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/fast/innerHTML/innerHTML-template-crash.xhtml View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/fast/innerHTML/innerHTML-template-crash-expected.xhtml View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/fast/innerHTML/innerHTML-xml.xhtml View 1 chunk +0 lines, -53 lines 0 comments Download
D LayoutTests/fast/innerHTML/innerHTML-xml-expected.txt View 1 chunk +0 lines, -25 lines 0 comments Download
M LayoutTests/fast/loader/delete-inside-cancelTimer-expected.txt View 2 chunks +4 lines, -0 lines 0 comments Download
M LayoutTests/svg/css/script-tests/svg-attribute-length-parsing.js View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Element.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/dom/Element.cpp View 3 chunks +0 lines, -46 lines 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/editing/markup.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/markup.cpp View 1 chunk +0 lines, -14 lines 0 comments Download
M Source/core/html/HTMLElement.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 chunk +58 lines, -0 lines 0 comments Download
M Source/core/html/HTMLElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLTreeBuilder.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLTreeBuilder.cpp View 7 chunks +11 lines, -27 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yurys
Committed patchset #1 manually as r160914 (presubmit successful).
7 years, 1 month ago (2013-10-30 09:03:07 UTC) #1
mvrable
Adding karenlees to the CC list to keep her informed as she is most familiar ...
7 years, 1 month ago (2013-10-30 17:03:14 UTC) #2
davve
On 2013/10/30 17:03:14, mvrable wrote: > Adding karenlees to the CC list to keep her ...
7 years, 1 month ago (2013-10-30 21:20:31 UTC) #3
felt
On 2013/10/30 21:20:31, davve wrote: > On 2013/10/30 17:03:14, mvrable wrote: > > Adding karenlees ...
7 years, 1 month ago (2013-10-30 21:23:09 UTC) #4
davve
On 2013/10/30 21:23:09, felt wrote: > On 2013/10/30 21:20:31, davve wrote: > > On 2013/10/30 ...
7 years, 1 month ago (2013-10-30 21:30:06 UTC) #5
davve
On 2013/10/30 21:30:06, davve wrote: > On 2013/10/30 21:23:09, felt wrote: > > On 2013/10/30 ...
7 years, 1 month ago (2013-10-30 21:32:16 UTC) #6
davve
7 years, 1 month ago (2013-10-30 21:42:18 UTC) #7
Message was sent while issue was closed.
> But I don't think there is a blink roll waiting on this though. I haven't
> checked commit on the re-land in blink.

Since you're helping me with getting the test disabled, I've now added the
re-land to CQ. Thanks again for your help!

Powered by Google App Engine
This is Rietveld 408576698